Skip to content

Bigtable: update pom.xml to fail loudly when an invalid profile id is passed - #6141

Merged
chingor13 merged 1 commit into
googleapis:masterfrom
igorbernstein2:enforce-valid-profile
Aug 26, 2019
Merged

Bigtable: update pom.xml to fail loudly when an invalid profile id is passed#6141
chingor13 merged 1 commit into
googleapis:masterfrom
igorbernstein2:enforce-valid-profile

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor

Bigtable uses maven profiles for running integration tests. If the user mistypes the profile id, the test profile isn't activated and the build succeeds, giving a false positive result. This PR will just fail the build

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

… passed
Bigtable uses maven profiles for running integration tests. If the user mistypes the profile id, the test profile isn't activated and the build succeeds, giving a false positive result. This PR will just fail the build
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2019
@igorbernstein2igorbernstein2 added api: bigtable Issues related to the Bigtable API. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 22, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2019
@chingor13chingor13 self-assigned this Aug 26, 2019
@codecov

codecovBot commented Aug 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6141 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #6141 +/- ##
============================================
+ Coverage 47.38% 47.63% +0.24% - Complexity 27197 27708 +511 
============================================
Files 2523 2524 +1 Lines 274600 277456 +2856 Branches 31378 31835 +457 ============================================
+ Hits 130124 132157 +2033 - Misses 134863 135815 +952 + Partials 9613 9484 -129
Impacted FilesCoverage ΔComplexity Δ
...a/com/google/cloud/firestore/DocumentSnapshot.java85.16% <0%> (-0.56%)77% <0%> (+22%)
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java84.8% <0%> (-0.07%)221% <0%> (+76%)
...main/java/com/google/cloud/firestore/Internal.java0% <0%> (ø)0% <0%> (?)
...ain/java/com/google/cloud/pubsub/v1/Publisher.java89.45% <0%> (+0.34%)40% <0%> (ø)⬇️
...n/java/com/google/cloud/spanner/jdbc/JdbcBlob.java84.32% <0%> (+0.74%)37% <0%> (+1%)⬆️
...n/java/com/google/cloud/spanner/jdbc/JdbcClob.java75.86% <0%> (+1.14%)30% <0%> (+1%)⬆️
...ud/bigtable/admin/v2/BigtableTableAdminClient.java81.31% <0%> (+1.31%)46% <0%> (+19%)⬆️
...pute/v1/ProjectRegionInstanceGroupManagerName.java62% <0%> (+1.7%)10% <0%> (+2%)⬆️
...te/v1/ProjectRegionInterconnectAttachmentName.java62% <0%> (+1.7%)10% <0%> (+2%)⬆️
.../compute/v1/ProjectRegionTargetVpnGatewayName.java61.61% <0%> (+1.91%)10% <0%> (+2%)⬆️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e97c3...91ef59f. Read the comment docs.

@chingor13
chingor13 merged commit a7063d2 into googleapis:masterAug 26, 2019
@igorbernstein2
igorbernstein2 deleted the enforce-valid-profile branch August 26, 2019 17:38
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
… passed (googleapis#6141)
Bigtable uses maven profiles for running integration tests. If the user mistypes the profile id, the test profile isn't activated and the build succeeds, giving a false positive result. This PR will just fail the build
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2@chingor13@googlebot