Skip to content

spanner-jdbc: Add tests for JdbcConnection - #6157

Merged
olavloite merged 2 commits into
googleapis:masterfrom
olavloite:spanner-jdbc-add-tests-for-connection
Aug 27, 2019
Merged

spanner-jdbc: Add tests for JdbcConnection#6157
olavloite merged 2 commits into
googleapis:masterfrom
olavloite:spanner-jdbc-add-tests-for-connection

Conversation

@olavloite

Copy link
Copy Markdown
Contributor

Adds additional tests for JdbcConnection. Also fixes a small issue in JdbcConnection that caused the method isValid(int) to throw an exception when called on a closed connection, instead of returning false as it should have.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2019
@kolea2

Copy link
Copy Markdown
Contributor

LGTM just needs a rebase

@olavloite
olavloiteforce-pushed the spanner-jdbc-add-tests-for-connection branch from 9b0f79f to f610444CompareAugust 26, 2019 15:49
@codecov

codecovBot commented Aug 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6157 into master will increase coverage by 0.05%.
The diff coverage is 75%.

Impacted file tree graph

@@ Coverage Diff @@## master #6157 +/- ##
============================================
+ Coverage 47.41% 47.47% +0.05% - Complexity 27258 27402 +144 
============================================
Files 2524 2524 Lines 274663 274664 +1 Branches 31414 31414 ============================================
+ Hits 130239 130402 +163 + Misses 134783 134621 -162 
Partials 9641 9641
Impacted FilesCoverage ΔComplexity Δ
.../com/google/cloud/spanner/jdbc/JdbcConnection.java56.96% <75%> (+26.58%)41 <0> (+24)⬆️
...ain/java/com/google/cloud/pubsub/v1/Publisher.java89.11% <0%> (-0.35%)40% <0%> (ø)
...gle/cloud/spanner/jdbc/AbstractJdbcConnection.java65.27% <0%> (+1.38%)21% <0%> (+1%)⬆️
...ogle/cloud/spanner/jdbc/AbstractJdbcStatement.java55.26% <0%> (+5.26%)29% <0%> (+5%)⬆️
...ogle/cloud/spanner/jdbc/AbstractJdbcResultSet.java100% <0%> (+95.79%)117% <0%> (+114%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bfc925...f610444. Read the comment docs.

@olavloite
olavloite merged commit b188bf3 into googleapis:masterAug 27, 2019
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
* isValid should return false and not SQLException when closed
* add tests for JdbcConnection
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite@kolea2@googlebot