Skip to content

spanner-jdbc: Add tests for JdbcStatement - #6158

Merged
kolea2 merged 2 commits into
googleapis:masterfrom
olavloite:spanner-jdbc-add-tests-for-statement
Aug 26, 2019
Merged

spanner-jdbc: Add tests for JdbcStatement#6158
kolea2 merged 2 commits into
googleapis:masterfrom
olavloite:spanner-jdbc-add-tests-for-statement

Conversation

@olavloite

Copy link
Copy Markdown
Contributor

Adds additional tests for JdbcStatement. Also fixes an issue that executing statements and requesting generated keys to be returned should throw a SQLFeatureNotSupportedException.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2019
@codecov

codecovBot commented Aug 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6158 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #6158 +/- ##
============================================
+ Coverage 47.38% 47.39% +<.01% - Complexity 27182 27192 +10 
============================================
Files 2524 2524 Lines 274612 274614 +2 Branches 31383 31385 +2 ============================================
+ Hits 130125 130150 +25 + Misses 134874 134851 -23 
Partials 9613 9613
Impacted FilesCoverage ΔComplexity Δ
.../com/google/cloud/spanner/jdbc/JdbcConnection.java30.37% <ø> (ø)17 <0> (ø)⬇️
...a/com/google/cloud/spanner/jdbc/JdbcStatement.java67.74% <100%> (+16.1%)38 <0> (+10)⬆️
...ain/java/com/google/cloud/pubsub/v1/Publisher.java89.11% <0%> (-0.35%)40% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2f465...46165ae. Read the comment docs.

@kolea2
kolea2 merged commit 822290e into googleapis:masterAug 26, 2019
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
* throw exception when called with RETURN_GENERATED_KEYS
* add tests for JdbcStatement
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite@kolea2@googlebot