Skip to content

Update BigTable conformance tests (#5901) - #6166

Merged
BenWhitehead merged 4 commits into
googleapis:masterfrom
BenWhitehead:bigtable-conformance-tests-update
Aug 26, 2019
Merged

Update BigTable conformance tests (#5901)#6166
BenWhitehead merged 4 commits into
googleapis:masterfrom
BenWhitehead:bigtable-conformance-tests-update

Conversation

@BenWhitehead

@BenWhiteheadBenWhitehead commented Aug 26, 2019

Copy link
Copy Markdown
Contributor
  • Refactor ReadRowsMergingAcceptanceTest to use the generated Java
    Protobuf classes from the google-cloud-conformance-test module.
    The format read from is still json.
  • Update to use the latest revision of the conformance-tests data.

@BenWhitehead
Update BigTable conformance tests (#5901)
2ad497e
* Refactor ReadRowsMergingAcceptanceTest to use the generated Java
Protobuf classes from the google-cloud-conformance-test module.
The format read from is still json.
* Update to use the latest revision of the conformance-tests data.
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2019
igorbernstein2
igorbernstein2 requested changes Aug 26, 2019
View reviewed changes

@igorbernstein2igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting all of the clients aligned!

Comment threadgoogle-cloud-clients/google-cloud-bigtable/pom.xml
Comment thread...test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java Outdated
Comment thread...test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java Outdated
Comment thread...test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java Outdated
Comment thread...test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java Outdated
Comment thread...test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java
@codecov

codecovBot commented Aug 26, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@8bfa2c2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #6166 +/- ##
=========================================
Coverage ? 46.82% Complexity ? 25936 =========================================
Files ? 2524 Lines ? 269245 Branches ? 30390 =========================================
Hits ? 126064 Misses ? 133694 Partials ? 9487

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bfa2c2...264899b. Read the comment docs.

igorbernstein2
igorbernstein2 approved these changes Aug 26, 2019
View reviewed changes

@igorbernstein2igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks again for normalizing expectations across clients!

@BenWhitehead

BenWhitehead commented Aug 26, 2019

Copy link
Copy Markdown
ContributorAuthor

Failing test in the windows build is from the flaky spanner testsuite.

@BenWhitehead
BenWhitehead merged commit 6de998c into googleapis:masterAug 26, 2019
@BenWhitehead
BenWhitehead deleted the bigtable-conformance-tests-update branch August 26, 2019 19:53
@kolea2kolea2 mentioned this pull request Aug 28, 2019
Merged
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@BenWhitehead
Update BigTable conformance tests (googleapis#5901) (googleapis#6166)
d76951b
* Update BigTable conformance tests (googleapis#5901)
* Refactor ReadRowsMergingAcceptanceTest to use the generated Java
Protobuf classes from the google-cloud-conformance-test module.
The format read from is still json.
* Update to use the latest revision of the conformance-tests data.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2igorbernstein2igorbernstein2 approved these changes
@kolea2kolea2Awaiting requested review from kolea2

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BenWhitehead@igorbernstein2@googlebot