Uh oh!
There was an error while loading. Please reload this page.
Spanner: Remove tracing implementation from tests - #6176
Merged
skuruppu merged 1 commit intoAug 28, 2019
Conversation
OpenCensus added a finalizer that checks that all spans have been closed in the latest version. Using tracer implementations in combination with tests therefore spams the logs with a lot of warnings, as much test code is deliberately only executing part of for example a transaction.
olavloiteforce-pushed
the
spanner-remove-tracing-from-tests
branch
from
August 27, 2019 15:38
3cb3691 to
3ed7325CompareCodecov Report
@@ Coverage Diff @@## master #6176 +/- ##
============================================
- Coverage 47.5% 47.14% -0.37% + Complexity 27432 25967 -1465
============================================
Files 2523 2523 Lines 274592 269316 -5276 Branches 31401 31199 -202 ============================================
- Hits 130439 126960 -3479 + Misses 134520 133657 -863 + Partials 9633 8699 -934
Continue to review full report at Codecov.
|
skuruppu
approved these changes
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCensus added a finalizer that checks that all spans have been closed in the latest version. Using tracer implementations in combination with tests therefore spams the logs with a lot of warnings, as much test code is deliberately only executing part of for example a transaction.