Skip to content

Spanner: Remove tracing implementation from tests - #6176

Merged
skuruppu merged 1 commit into
googleapis:masterfrom
olavloite:spanner-remove-tracing-from-tests
Aug 28, 2019
Merged

Spanner: Remove tracing implementation from tests#6176
skuruppu merged 1 commit into
googleapis:masterfrom
olavloite:spanner-remove-tracing-from-tests

Conversation

@olavloite

Copy link
Copy Markdown
Contributor

OpenCensus added a finalizer that checks that all spans have been closed in the latest version. Using tracer implementations in combination with tests therefore spams the logs with a lot of warnings, as much test code is deliberately only executing part of for example a transaction.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2019
OpenCensus added a finalizer that checks that all spans have
been closed in the latest version. Using tracer implementations
in combination with tests therefore spams the logs with a lot
of warnings, as much test code is deliberately only executing
part of for example a transaction.
@olavloite
olavloiteforce-pushed the spanner-remove-tracing-from-tests branch from 3cb3691 to 3ed7325CompareAugust 27, 2019 15:38
@codecov

codecovBot commented Aug 27, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6176 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #6176 +/- ##
============================================
- Coverage 47.5% 47.14% -0.37% + Complexity 27432 25967 -1465 
============================================
Files 2523 2523 Lines 274592 269316 -5276 Branches 31401 31199 -202 ============================================
- Hits 130439 126960 -3479 + Misses 134520 133657 -863 + Partials 9633 8699 -934
Impacted FilesCoverage ΔComplexity Δ
...m/google/cloud/vision/v1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java63.41% <0%> (-2.5%)12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java55.88% <0%> (-2.46%)9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java55.88% <0%> (-2.46%)9% <0%> (-2%)
...oogle/cloud/language/v1/LanguageServiceClient.java79.16% <0%> (-2.32%)26% <0%> (-9%)
... and 640 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48ee81...3ed7325. Read the comment docs.

@skuruppu
skuruppu merged commit bcf4068 into googleapis:masterAug 28, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite@skuruppu@googlebot