Skip to content

Unflake SpannerGaxRetryTest - #6184

Merged
olavloite merged 1 commit into
googleapis:masterfrom
kolea2:spanner-gaxtest
Aug 28, 2019
Merged

Unflake SpannerGaxRetryTest#6184
olavloite merged 1 commit into
googleapis:masterfrom
kolea2:spanner-gaxtest

Conversation

@kolea2

Copy link
Copy Markdown
Contributor

Reverting HUNDRED_MS to ONE_SECOND

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2019
@codecov

codecovBot commented Aug 27, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6184 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #6184 +/- ##
============================================
- Coverage 47.5% 47.22% -0.29% 
Complexity 27432 27432 ============================================
Files 2523 2523 Lines 274592 274451 -141 Branches 31401 30578 -823 ============================================
- Hits 130439 129597 -842 + Misses 134520 134432 -88 - Partials 9633 10422 +789
Impacted FilesCoverage ΔComplexity Δ
...va/com/google/cloud/compute/v1/InstanceClient.java48.8% <0%> (-6.45%)143% <0%> (ø)
.../com/google/cloud/compute/v1/RegionDiskClient.java47.9% <0%> (-5.99%)43% <0%> (ø)
...ava/com/google/cloud/compute/v1/ProjectClient.java51.14% <0%> (-5.94%)55% <0%> (ø)
...ava/com/google/cloud/compute/v1/NetworkClient.java49.63% <0%> (-5.84%)35% <0%> (ø)
...ava/com/google/cloud/compute/v1/LicenseClient.java50.41% <0%> (-5.79%)31% <0%> (ø)
...va/com/google/cloud/compute/v1/SnapshotClient.java50% <0%> (-5.74%)31% <0%> (ø)
.../java/com/google/cloud/compute/v1/ImageClient.java49.04% <0%> (-5.74%)43% <0%> (ø)
.../google/cloud/compute/v1/TargetSslProxyClient.java48.57% <0%> (-5.72%)35% <0%> (ø)
.../google/cloud/compute/v1/SecurityPolicyClient.java48.1% <0%> (-5.7%)39% <0%> (ø)
...d/compute/v1/RegionInstanceGroupManagerClient.java48.81% <0%> (-5.69%)51% <0%> (ø)
... and 178 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48ee81...022d6d6. Read the comment docs.

@olavloiteolavloite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good idea.

@olavloite
olavloite merged commit de9eea8 into googleapis:masterAug 28, 2019
@kolea2
kolea2 deleted the spanner-gaxtest branch August 28, 2019 14:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kolea2@olavloite@googlebot