Skip to content

Revert "Fix failing bigquery ITs due to missing queryPlan"#643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aozarov wants to merge 1 commit into from
Closed

Revert "Fix failing bigquery ITs due to missing queryPlan" #643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/ITBigQueryTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -654,10 +654,9 @@ public void testQuery() throws InterruptedException {
rowCount++;
}
assertEquals(2, rowCount);
// todo(mziccard) uncomment as soon as #624 is closed
// Job queryJob = bigquery.getJob(response.jobId());
// JobStatistics.QueryStatistics statistics = queryJob.statistics();
// assertNotNull(statistics.queryPlan());
Job queryJob = bigquery.getJob(response.jobId());
JobStatistics.QueryStatistics statistics = queryJob.statistics();
assertNotNull(statistics.queryPlan());
}

@Test
Expand DownExpand Up@@ -822,10 +821,9 @@ public void testQueryJob() throws InterruptedException {
}
assertEquals(2, rowCount);
assertTrue(bigquery.delete(DATASET, tableName));
// todo(mziccard) uncomment as soon as #624 is closed
// Job queryJob = bigquery.getJob(remoteJob.jobId());
// JobStatistics.QueryStatistics statistics = queryJob.statistics();
// assertNotNull(statistics.queryPlan());
Job queryJob = bigquery.getJob(remoteJob.jobId());
JobStatistics.QueryStatistics statistics = queryJob.statistics();
assertNotNull(statistics.queryPlan());
}

@Test
Expand Down