Uh oh!
There was an error while loading. Please reload this page.
chore: Display Java Diff between Monorepo and Split Repos - #8448
Closed
lqiu96 wants to merge 1 commit into
Closed
Conversation
lqiu96force-pushed
the
main-diff_java
branch
2 times, most recently
from
September 23, 2022 19:18
3399111 to
16e7474Comparegithub-actionsBotforce-pushed
the
main-diff_java
branch
from
September 23, 2022 20:13
16e7474 to
2347acaComparesuztomo
reviewed
Sep 26, 2022
Comment on lines
+28
to
+27
| return COMPUTE_PREFIX + "-" + placeholder + "-" + UUID.randomUUID().toString().substring(0, 8); | ||
| return "gapic-" + placeholder + UUID.randomUUID().toString().substring(0, 8); |
suztomo
reviewed
Sep 26, 2022
| import com.google.container.v1.ListOperationsResponse; | ||
| import com.google.container.v1.NodePool; | ||
| import com.google.container.v1.Operation; | ||
| import com.google.container.v1.Operation.Status; |
github-actionsBotforce-pushed
the
main-diff_java
branch
6 times, most recently
from
September 26, 2022 20:28
f43fa85 to
14cbe56Comparesuztomo
commented
Sep 26, 2022
Member
You want to have the pull request on the diff script and Java code diff separated. |
github-actionsBotforce-pushed
the
main-diff_java
branch
4 times, most recently
from
September 27, 2022 15:06
82d9684 to
67717ecComparegithub-actionsBotforce-pushed
the
main-diff_java
branch
from
September 27, 2022 16:07
fe79169 to
2ca0a81CompareMemberAuthor
RESOLVED: Data-Catalog Diff
RESOLVED: Dataproc Diff
Web Security Scanner DiffShould be resolved in: #8471 Java Vision DiffShould be resolved in: #8472 Java-BigQuery-Data-ExhangeThis is an odd difference... Monorepo PR:
Split Repo PR
Diff in files:
|
github-actionsBotforce-pushed
the
main-diff_java
branch
2 times, most recently
from
September 27, 2022 19:47
d6f82d2 to
6468782Compare
This was referenced Sep 27, 2022
github-actionsBotforce-pushed
the
main-diff_java
branch
2 times, most recently
from
September 28, 2022 14:50
22ced07 to
ad8245fComparegithub-actionsBotforce-pushed
the
main-diff_java
branch
3 times, most recently
from
October 4, 2022 17:50
a308312 to
342ffc0Comparesuztomo
commented
Oct 4, 2022
Member
The inifinite diff probably is caused by the recent protobuf changes applied to split repos. |
github-actionsBotforce-pushed
the
main-diff_java
branch
14 times, most recently
from
October 6, 2022 15:13
224ba2f to
391b6f7Comparegithub-actionsBotforce-pushed
the
main-diff_java
branch
8 times, most recently
from
October 7, 2022 15:11
b38284d to
2cea3b1CompareMemberAuthor
To Fix- Java Diffs:All Resolved Resolved/ Non-Issuejava-publicca -- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP