Add default retry params that align with SLA by ajkannan · Pull Request #860 · googleapis/google-cloud-java

ajkannan · 2016-04-06T01:30:06Z

Some notes/questions:

I've changed the retry settings for services that explicitly state the back-off requirement. However, since they're all the same, do you think that's a general recommendation? If so, do you think we should change RetryParams.defaultInstance() instead?
I've also increased the total retry period to 80000, since 1 + 2 + 4 + 8 + 16 + 32 = 63 seconds, which is greater than the 50 default

coveralls · 2016-04-06T01:36:19Z

Changes Unknown when pulling 982b808 on ajkannan:sla-specific-retry into * on GoogleCloudPlatform:master*.

mziccard · 2016-04-06T07:57:37Z

However, since they're all the same, do you think that's a general recommendation?

I can't be sure of this but given that all params look the same I would tend to avoid replicating them in all services. Also this new retry params should work also for other services.

…igquery sla

ajkannan · 2016-04-06T20:54:20Z

Took into account feedback; ready for another pass.

coveralls · 2016-04-06T21:02:06Z

Changes Unknown when pulling 07e467c on ajkannan:sla-specific-retry into * on GoogleCloudPlatform:master*.

Sign in to view

 private final double retryDelayBackoffFactor;
 private final long totalRetryPeriodMillis;

+ // Some services may have different backoff requirements listed in their SLAs. Be sure to override


aozarov · 2016-04-07T02:08:05Z

LGTM. Feel free to merge after considering the Javadoc suggestions.

coveralls · 2016-04-07T16:35:56Z

Changes Unknown when pulling 3ba911a on ajkannan:sla-specific-retry into * on GoogleCloudPlatform:master*.

🤖 I have created a release *beep* *boop* --- ## [3.3.1](googleapis/java-monitoring@v3.3.0...v3.3.1) (2022-07-01) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#869](googleapis/java-monitoring#869)) ([76f9358](googleapis/java-monitoring@76f9358)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.0 ([#860](googleapis/java-monitoring#860)) ([635c917](googleapis/java-monitoring@635c917)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.1 ([#861](googleapis/java-monitoring#861)) ([44b0239](googleapis/java-monitoring@44b0239)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.2 ([#870](googleapis/java-monitoring#870)) ([976db41](googleapis/java-monitoring@976db41)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…center to v2.7.0 (#860) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-securitycenter](https://togithub.com/googleapis/java-securitycenter) | `2.6.0` -> `2.7.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-securitycenter/2.7.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-securitycenter/2.7.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-securitycenter/2.7.0/compatibility-slim/2.6.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-securitycenter/2.7.0/confidence-slim/2.6.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-securitycenter).

….3 (#860) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.github.bonigarcia:webdrivermanager](https://bonigarcia.dev/webdrivermanager/) ([source](https://togithub.com/bonigarcia/webdrivermanager)) | `5.2.2` -> `5.2.3` | [![age](https://badges.renovateapi.com/packages/maven/io.github.bonigarcia:webdrivermanager/5.2.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.github.bonigarcia:webdrivermanager/5.2.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.github.bonigarcia:webdrivermanager/5.2.3/compatibility-slim/5.2.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.github.bonigarcia:webdrivermanager/5.2.3/confidence-slim/5.2.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bonigarcia/webdrivermanager</summary> ### [`v5.2.3`](https://togithub.com/bonigarcia/webdrivermanager/blob/HEAD/CHANGELOG.md#523---2022-08-03) ##### Added - Use resolution cache also when latest driver is downloaded (for preventing 403 error for geckodriver) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recaptchaenterprise).

🤖 I have created a release *beep* *boop* --- ## [3.0.4](googleapis/java-recaptchaenterprise@v3.0.3...v3.0.4) (2022-08-03) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#856](googleapis/java-recaptchaenterprise#856)) ([9d2c1d7](googleapis/java-recaptchaenterprise@9d2c1d7)) * update dependency io.github.bonigarcia:webdrivermanager to v5.2.3 ([#860](googleapis/java-recaptchaenterprise#860)) ([eb71066](googleapis/java-recaptchaenterprise@eb71066)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.8.2](googleapis/java-core@v2.8.1...v2.8.2) (2022-07-13) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-core/issues/1485)) ([#866](googleapis/java-core#866)) ([8a8ac99](googleapis/java-core@8a8ac99)) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v1.35.2 ([#859](googleapis/java-core#859)) ([6b51a1c](googleapis/java-core@6b51a1c)) * update dependency com.google.api:gax-bom to v2.18.3 ([#860](googleapis/java-core#860)) ([f5a5278](googleapis/java-core@f5a5278)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.9.1 ([#855](googleapis/java-core#855)) ([4ec6635](googleapis/java-core@4ec6635)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.5.0 ([#862](googleapis/java-core#862)) ([19aebbe](googleapis/java-core@19aebbe)) * update dependency com.google.http-client:google-http-client-bom to v1.42.1 ([#861](googleapis/java-core#861)) ([4d7548b](googleapis/java-core@4d7548b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Manually brings in changes from https://togithub.com/googleapis/synthtool/pull/1594. [Renovate.json is excluded in owlbot](https://togithub.com/googleapis/java-shared-dependencies/blob/675837378642f39fe55c0e30b62755b9185bee3d/owlbot.py#L22) so the changes in synthtool couldn't be applied. This is to stop update dep PRs like [this one](https://togithub.com/googleapis/java-shared-dependencies/pull/859) from showing up in the repo.

… (#860) Source-Link: googleapis/synthtool@53a58c2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:3c950ed12391ebaffd1ee66d0374766a1c50144ebe6a7a0042300b2e6bb5856b

Source-Link: googleapis/synthtool@f58d313 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f14e3fefe8e361e85752bd9890c8e56f2fe25f1e89cbb9597e4e3c7a429203a3 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [importlib-metadata](https://togithub.com/python/importlib_metadata) | `==4.8.3` -> `==4.12.0` | [![age](https://badges.renovateapi.com/packages/pypi/importlib-metadata/4.12.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/importlib-metadata/4.12.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/importlib-metadata/4.12.0/compatibility-slim/4.8.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/importlib-metadata/4.12.0/confidence-slim/4.8.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datastore).

…ugin to v3.11.0 (#860) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-site-plugin](https://maven.apache.org/plugins/) ([source](https://togithub.com/apache/maven-site-plugin)) | `3.10.0` -> `3.11.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-site-plugin/3.11.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-site-plugin/3.11.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-site-plugin/3.11.0/compatibility-slim/3.10.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-site-plugin/3.11.0/confidence-slim/3.10.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).

…leapis#1350) (googleapis#860) Source-Link: googleapis/synthtool@53a58c2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:3c950ed12391ebaffd1ee66d0374766a1c50144ebe6a7a0042300b2e6bb5856b

…ugin to v3.11.0 (#860) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-site-plugin](https://maven.apache.org/plugins/) ([source](https://togithub.com/apache/maven-site-plugin)) | `3.10.0` -> `3.11.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-site-plugin/3.11.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-site-plugin/3.11.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-site-plugin/3.11.0/compatibility-slim/3.10.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-site-plugin/3.11.0/confidence-slim/3.10.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).

Fixes a NullPointerException when creating a Path object with a bucket that doesn't exist. This only occurred when autoDetectRequesterPays = true. Refs: #857 Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-storage-nio/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes#857☕️ If you write sample code, please follow the [samples format]( https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).

This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2021-06-04 16:44:11,494 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-bigtable/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working tree clean 2021-06-04 16:44:13,016 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/23d7657a-d55a-4f71-9335-90967eef596a/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)

Add default retry params that align with SLA
982b808

ajkannan added the api: core label Apr 6, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2016

modify default retry params to conform with datastore, storage, and b…
07e467c
…igquery sla

aozarov reviewed Apr 7, 2016
View reviewed changes

Javadoc adjustments
3ba911a

ajkannan merged commit bdc472a into googleapis:masterApr 7, 2016

ajkannan deleted the sla-specific-retry branch April 7, 2016 16:36

github-actionsBot pushed a commit that referenced this pull request Jul 14, 2022
chore: add native image checks as required (#860)
1788785

Navigation Menu

Uh oh!

Add default retry params that align with SLA - #860

Add default retry params that align with SLA#860
ajkannan merged 3 commits into
googleapis:masterfrom
ajkannan:sla-specific-retry

ajkannan commented Apr 6, 2016

Uh oh!

coveralls commented Apr 6, 2016

Uh oh!

mziccard commented Apr 6, 2016

Uh oh!

ajkannan commented Apr 6, 2016

Uh oh!

coveralls commented Apr 6, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Apr 7, 2016

Uh oh!

coveralls commented Apr 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

ajkannan commented Apr 6, 2016

Uh oh!

coveralls commented Apr 6, 2016

Uh oh!

mziccard commented Apr 6, 2016

Uh oh!

ajkannan commented Apr 6, 2016

Uh oh!

coveralls commented Apr 6, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Apr 7, 2016

Uh oh!

coveralls commented Apr 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants