Skip to content

chore: Fix update_versions.sh to include beyondcorp - #8619

Merged
gcf-merge-on-green[bot] merged 5 commits into
mainfrom
main-release_fix
Oct 17, 2022
Merged

chore: Fix update_versions.sh to include beyondcorp#8619
gcf-merge-on-green[bot] merged 5 commits into
mainfrom
main-release_fix

Conversation

@lqiu96

@lqiu96lqiu96 commented Oct 17, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This PR resets only the beyondcorp-* module's version.txt

suztomo
suztomo reviewed Oct 17, 2022
View reviewed changes
Comment thread.release-please-manifest.json
"java-websecurityscanner": "2.4.0",
"java-workflow-executions": "2.4.0",
"java-workflows": "2.4.0"
"java-bigqueryconnection": "2.5.6",

@suztomosuztomoOct 17, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems downgrading. But 2.6.0 release didn't go. So it's reasonable.

suztomo
suztomo requested changes Oct 17, 2022
View reviewed changes

@suztomosuztomo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you regenerate GAPIC BOM as well? The merged committish should be releasable.

@lqiu96

lqiu96 commented Oct 17, 2022

Copy link
Copy Markdown
MemberAuthor

Waiting for Mike's PR: #8621 before I make any further changes

@lqiu96

lqiu96 commented Oct 17, 2022

Copy link
Copy Markdown
MemberAuthor

I might have accidentally merged the old main commit in: bd889c0

Going to remove that commit. If any issues, I'll create a new PR.

@suztomo

suztomo commented Oct 17, 2022

Copy link
Copy Markdown
Member

@lqiu96 You have to regenerate BOM and release please config files.

Generated Files Sync / gapic-libraries-bom does not have diff from generated one

@lqiu96

lqiu96 commented Oct 17, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@lqiu96 You have to regenerate BOM and release please config files.

Generated Files Sync / gapic-libraries-bom does not have diff from generated one

It should be ./generation/generate_gapic_bom.sh, right? I ran this earlier and there were no diffs.

Oh, do I also need to run ./generation/apply_current_versions.sh?

@suztomo

suztomo commented Oct 17, 2022

Copy link
Copy Markdown
Member

apply_current_versions.sh

Right. I see the checks are green now.

@lqiu96lqiu96 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 17, 2022
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 50afbb7 into mainOct 17, 2022
@gcf-merge-on-green
gcf-merge-on-greenBot deleted the main-release_fix branch October 17, 2022 16:30
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 17, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomosuztomosuztomo approved these changes
@meltsufinmeltsufinAwaiting requested review from meltsufin
@ddixit14ddixit14Awaiting requested review from ddixit14

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lqiu96@suztomo