Skip to content

open external links in new tab - #1095

Closed
VikramTiwari wants to merge 4 commits into
googleapis:masterfrom
VikramTiwari:master
Closed

open external links in new tab#1095
VikramTiwari wants to merge 4 commits into
googleapis:masterfrom
VikramTiwari:master

Conversation

@VikramTiwari

@VikramTiwariVikramTiwari commented Jan 28, 2016

Copy link
Copy Markdown

I think this is all, but there might be more such links/

Regarding: #1094

@VikramTiwari
open external links externally
a48a00d
I think this is all, but there might be more.
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2016
@VikramTiwariVikramTiwari changed the title open external links externallyopen external links in new tabJan 28, 2016
@VikramTiwari
another fix on samples
b508040
instance id should be string
@VikramTiwari
string, not code
d067092
my bad! :P
@stephenplusplus

stephenplusplus commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

Thanks for sending this, @VikramTiwari!

@callmehiphop is this the best way to open external links in new windows, or can we use some fancy JS to handle this for us? (edit: to clarify, I mean can we automate assigning target="_blank" to external links?)

callmehiphop
callmehiphop reviewed Jan 29, 2016
View reviewed changes
Comment threaddocs/site/components/language-switcher/language-switcher.html

This comment was marked as spam.

Sign in to view

@callmehiphop

callmehiphop commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

is this the best way to open external links in new windows, or can we use some fancy JS to handle this for us?

Well, if we wanted to simplify the whole thing we could create an angular directive to overload the <a> tag and set the target dynamically.

@stephenplusplus

stephenplusplus commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

I'm cool with that, since a lot of our links are going to be coming from Markdown in the docs.

@callmehiphop

callmehiphop commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

Cool!

@VikramTiwari did you want to take that on? Otherwise I can get to it later :)

@VikramTiwari

VikramTiwari commented Jan 29, 2016

Copy link
Copy Markdown
Author

I can take a stab at it, but what would be the logic that we would like to use here? Not all absolute links are external links.

@callmehiphop

callmehiphop commented Jan 29, 2016

Copy link
Copy Markdown
Contributor

We use a CSS class called skip-external-link, so I would think any absolute URL missing that class would qualify?

@stephenplusplus thoughts?

@stephenplusplus

stephenplusplus commented Jan 30, 2016

Copy link
Copy Markdown
Contributor

Sounds sane to me.

@stephenplusplus

stephenplusplus commented Feb 5, 2016

Copy link
Copy Markdown
Contributor

@callmehiphop since all of the docs changes we've pushed, will @VikramTiwari rebasing be enough, or is there anything else to it?

@callmehiphop

callmehiphop commented Feb 5, 2016

Copy link
Copy Markdown
Contributor

Nope :(

We'll probably have to mirror these changes in https://github.com/GoogleCloudPlatform/gcloud-common

@stephenplusplus

stephenplusplus commented Feb 8, 2016

Copy link
Copy Markdown
Contributor

@VikramTiwari we moved most of our docs to a centralized repo, so that the other languages (gcloud-ruby, gcloud-php, etc) can set up their docs as well.

The new location is https://github.com/GoogleCloudPlatform/gcloud-common/tree/master/site/src -- I believe the task now is finding links across gcloud-common that need to be updated, as well as some changes still inside this repo. Are you still up for it? It's totally understandable if you'd rather have us do it. Thanks for your help so far and sorry for the curveball!

// @callmehiphop is all of that ^ correct?

@callmehiphop

callmehiphop commented Feb 8, 2016

Copy link
Copy Markdown
Contributor

@stephenplusplus yep!

@VikramTiwari

VikramTiwari commented Feb 8, 2016

Copy link
Copy Markdown
Author

Hey @stephenplusplus Good move for centralized repo. I will try to do the changes at that repo by this weekend. Will keep you all updated.

@stephenplusplus

stephenplusplus commented Feb 8, 2016

Copy link
Copy Markdown
Contributor

Awesome, thanks!

@stephenplusplus

stephenplusplus commented Mar 8, 2016

Copy link
Copy Markdown
Contributor

I'll close this up and let #1094 track our progress.

miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025
@release-please
chore: release 2.24.3 (#1095)
d620fd8
🤖 I have created a release \*beep\* \*boop\*
---
### [2.24.3](https://www.github.com/googleapis/gax-nodejs/compare/v2.24.2...v2.24.3) (2021-08-31)
### Bug Fixes
* use the full type name for ErrorInfo ([#1093](https://www.github.com/googleapis/gax-nodejs/issues/1093)) ([c1e646a](https://www.github.com/googleapis/gax-nodejs/commit/c1e646abf148ab55da4dcdfc65e7d2647d0208a9))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026
@release-please
chore(main): release 7.5.0 (#1095)
a1c952a
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Feb 5, 2026
@release-please
chore(main): release 7.5.0 (#1095)
82d3d91
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Feb 17, 2026
@release-please
chore(main): release 7.5.0 (#1095)
69feec3
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Feb 24, 2026
@yuchenshi
fix(settings): authenticate using fake bearer token when ssl is false (…
46a71e3
…#1095)
This fixesfirebase/firebase-js-sdk#3105 (comment).
Before this change, `db.settings({..., ssl: false})` will connect but without any credentials (similar to a client device that is not logged in), which causes Firestore Emulator to evaluate security rules for requests. This is surprising for an Admin SDK and it is extremely hard to troubleshoot.
After this change, the same code should correctly behave like admin. This also provides one additional way to get admin privileges in the Firestore Emulator if for some reasons the environment variables is not viable / desirable.
GautamSharda pushed a commit that referenced this pull request Mar 5, 2026
@gcf-owl-botBenjamin E. Coe
build: add auto-approve to Node libraries (#1100) (#1095)
70dd6ac
* build: add auto-approve to Node libraries
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Source-Link: googleapis/synthtool@5cae043
Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:65aa68f2242c172345d7c1e780bced839bfdc344955d6aa460aa63b4481d93e5
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VikramTiwari@stephenplusplus@callmehiphop@googlebot