datastore: support deferred results. fixes #77. by stephenplusplus · Pull Request #133 · googleapis/google-cloud-node

stephenplusplus · 2014-08-23T01:34:00Z

I thought I'd take a stab at #77. If a response from a dataset.get comes back with deferred keys, this will recursively call .get again, only executing the callback passed to the initial .get once, after having gathered all possible results.

Sign in to view

stephenplusplus · 2014-08-27T18:31:00Z

@rakyll Rebased, should be good to merge 👍

datastore: support deferred results. fixes#77.

rakyll · 2014-08-27T18:45:24Z

Great, thanks!

…or (#133) Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2b12f6c9-10d8-4a5e-b86e-af5827858559/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@ba9918c

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/9943226b-8e9b-44fd-b025-446fc572242a/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@363fe30

* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

* Allowed Labels for CreateInstance * Linting fix * enabling labels creation support for instance creation method * Added test for labels support for createInstance method * fixed linting issue * reverted package-lock.json changes

stephenplusplus mentioned this pull request Aug 23, 2014
datastore: Support LookupResponse deferred field #77
Closed

rakyll reviewed Aug 25, 2014
View reviewed changes

datastore: support deferred results.fixesgoogleapis#77.
473f55d

stephenplusplus force-pushed the deferred branch from ceb8122 to 473f55dCompare August 27, 2014 18:30

rakyll pushed a commit that referenced this pull request Aug 27, 2014
Merge pull request#133from stephenplusplus/deferred
72752dd
datastore: support deferred results. fixes#77.

rakyll merged commit 72752dd into googleapis:masterAug 27, 2014

sofisl mentioned this pull request Sep 16, 2022
migrate code from googleapis/nodejs-os-login #3366
Closed
4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022
fix(deps): update dependency google-gax to ^0.23.0 (#133)
f4dd1d8

sofisl pushed a commit that referenced this pull request Oct 5, 2022
fix(deps): update dependency google-gax to ^0.23.0 (#133)
fd6b81e

This was referenced Oct 5, 2022
migrate code from googleapis/nodejs-os-login #3388
Closed
migrate code from googleapis/nodejs-os-login #3389
Closed

sofisl pushed a commit that referenced this pull request Oct 8, 2022
fix(deps): update dependency google-gax to ^0.23.0 (#133)
49b7faa

sofisl mentioned this pull request Oct 11, 2022
migrate code from googleapis/nodejs-os-login #3391
Merged
4 tasks

sofisl pushed a commit that referenced this pull request Oct 12, 2022
chore: update eslintignore config (#133)
d95214e

This was referenced Oct 12, 2022
migrate code from googleapis/nodejs-resource-manager #3402
Merged
migrate code from googleapis/nodejs-phishing-protection #3406
Merged

sofisl pushed a commit that referenced this pull request Oct 13, 2022
fix: remove eslint, update gax, fix generated protos, run the generat…
12552d3
…or (#133) Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.

sofisl mentioned this pull request Oct 13, 2022
migrate code from googleapis/nodejs-monitoring-dashboards #3408
Merged
4 tasks

sofisl mentioned this pull request Nov 10, 2022
migrate code from googleapis/nodejs-text-to-speech #3528
Merged
4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022
refactor(samples): convert sample tests from ava to mocha (#133)
55cd3f2

sofisl pushed a commit that referenced this pull request Nov 10, 2022
docs: update readme badges (#133)
8924e32

This was referenced Nov 10, 2022
migrate code from googleapis/nodejs-tasks #3530
Merged
migrate code from googleapis/nodejs-monitoring #3545
Merged

sofisl pushed a commit that referenced this pull request Nov 11, 2022
chore(deps): update dependency sinon to v7 (#133)
53a0eee

sofisl pushed a commit that referenced this pull request Nov 11, 2022
docs: document version support goals (#133)
a49c157

sofisl mentioned this pull request Nov 11, 2022
migrate code from googleapis/nodejs-web-risk #3549
Merged
4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022
test: modernize mocha config (#133)
3a643f4

sofisl mentioned this pull request Feb 17, 2026
migrate code from googleapis/nodejs-datastore #7263
Merged
4 tasks

GautamSharda pushed a commit that referenced this pull request Feb 23, 2026
chore: fix samples linting (#133)
e3ed87f

GautamSharda mentioned this pull request Feb 23, 2026
migrate code from googleapis/nodejs-error-reporting #7294
Closed

sofisl pushed a commit that referenced this pull request Feb 24, 2026
Updating variable name for Transactions reads (#133)
3c3380f

sofisl pushed a commit that referenced this pull request Feb 25, 2026
add 'auto' options for contentType and gzip (#133)
4f26881

GautamSharda mentioned this pull request Feb 25, 2026
migrate code from googleapis/nodejs-bigquery-storage #7306
Closed
4 tasks

GautamSharda pushed a commit that referenced this pull request Feb 26, 2026
chore: fix samples linting (#133)
47c4312

GautamSharda mentioned this pull request Feb 26, 2026
migrate code from googleapis/nodejs-error-reporting #7308
Merged
4 tasks

sofisl pushed a commit that referenced this pull request Feb 26, 2026
Remove autoCreate for objects that return operations. (#133)
4057809

This was referenced Feb 26, 2026
migrate code from googleapis/nodejs-firestore #7311
Closed
migrate code from googleapis/nodejs-firestore #7410
Merged

GautamSharda mentioned this pull request Mar 5, 2026
migrate code from googleapis/nodejs-bigquery-storage #7496
Merged
4 tasks

codyoss pushed a commit that referenced this pull request Mar 5, 2026
chore: update CONTRIBUTING.md and make releaseType node (#133)
1782c58

codyoss mentioned this pull request Mar 5, 2026
migrate code from googleapis/nodejs-projectify #7511
Merged

codyoss pushed a commit that referenced this pull request Mar 9, 2026
chore: release 1.0.2 (#133)
68b904d
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

codyoss mentioned this pull request Mar 9, 2026
migrate code from googleapis/nodejs-paginator #7536
Closed

codyoss pushed a commit that referenced this pull request Mar 11, 2026
chore: release 1.0.2 (#133)
72edfb8
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]

codyoss mentioned this pull request Mar 11, 2026
migrate code from googleapis/nodejs-paginator #7590
Merged

GautamSharda mentioned this pull request Mar 12, 2026
migrate code from googleapis/nodejs-promisify #7595
Closed
4 tasks

GautamSharda pushed a commit that referenced this pull request Mar 12, 2026
docs: update link to client docs (#133)
00cebdb

GautamSharda mentioned this pull request Mar 12, 2026
migrate code from googleapis/nodejs-promisify #7596
Merged
4 tasks

GautamSharda pushed a commit that referenced this pull request Mar 12, 2026
docs: update link to client docs (#133)
d9d93a6

GautamSharda pushed a commit that referenced this pull request Mar 12, 2026
chore: release 0.18.5 (#133)
faba6eb

GautamSharda mentioned this pull request Mar 12, 2026
migrate code from googleapis/nodejs-common #7597
Merged
4 tasks

thiyaguk09 pushed a commit to thiyaguk09/google-cloud-node-fork that referenced this pull request Mar 18, 2026
add 'auto' options for contentType and gzip (googleapis#133)
d801bcb

GautamSharda mentioned this pull request Mar 23, 2026
migrate code from googleapis/nodejs-bigtable #7852
Merged
4 tasks

Navigation Menu

Uh oh!

datastore: support deferred results. fixes #77. - #133

datastore: support deferred results. fixes #77.#133
rakyll merged 1 commit into
googleapis:masterfrom
stephenplusplus:deferred

stephenplusplus commented Aug 23, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

stephenplusplus commented Aug 27, 2014

Uh oh!

rakyll commented Aug 27, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

stephenplusplus commented Aug 23, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

stephenplusplus commented Aug 27, 2014

Uh oh!

rakyll commented Aug 27, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants