Uh oh!
There was an error while loading. Please reload this page.
docs: gcloud-node or gcloud - #200
Conversation
ryanseys
commented
Sep 9, 2014
LGTM |
ryanseys
commented
Sep 9, 2014
You should remove the bit about gcloud-node and gcloud now. It doesn't make sense considering you're referring to the library as gcloud now. |
silvolu
commented
Sep 9, 2014
@beriberikix do we need any marketing input/validation here? |
rakyll
commented
Sep 9, 2014
@ryanseys, I made a few more changes. Does it look any better now? |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
stephenplusplus
commented
Sep 9, 2014
I left some notes on things that I know you didn't change in this PR, but I figured while you're in there, it's a good chance to address them before we forget. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
ryanseys
commented
Sep 10, 2014
I suffer from premature-LGTM'ing. I've added a few extra comments. |
beriberikix
commented
Sep 10, 2014
rakyll
commented
Sep 10, 2014
PTAL. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
rakyll
commented
Sep 10, 2014
PTAL |
beriberikix
commented
Sep 10, 2014
package manage resources on +the+ Google while the |
rakyll
commented
Sep 10, 2014
PTAL |
docs: gcloud-node or gcloud
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 392067151 Source-Link: googleapis/googleapis@06345f7 Source-Link: googleapis/googleapis-gen@95882b3
🤖 I have created a release \*beep\* \*boop\* --- ## [2.6.0](https://www.github.com/googleapis/nodejs-bigquery-storage/compare/v2.5.4...v2.6.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#200](https://www.github.com/googleapis/nodejs-bigquery-storage/issues/200)) ([ef2206c](https://www.github.com/googleapis/nodejs-bigquery-storage/commit/ef2206cf1087c23d144fbc4b50363efb4c6deab2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2f68300a-9812-4342-86c6-33ab267ece4f/targets Source-Link: googleapis/synthtool@be74d3e
We switch back and forth between gcloud and gcloud-node to distinguish it from the CLI. When title says gcloud, the description should not say gcloud-node?
But there is nothing to do for
Should I revert this change back?
