Skip to content

Return Error object for failed Api requests and fixed flaky test. - #36

Merged
rakyll merged 3 commits into
googleapis:masterfrom
silvolu:master
Jul 25, 2014
Merged

Return Error object for failed Api requests and fixed flaky test.#36
rakyll merged 3 commits into
googleapis:masterfrom
silvolu:master

Conversation

@silvolu

Copy link
Copy Markdown
Contributor

No description provided.

* Order in returned objects is coherent with returned keys, but not necessarily with the keys passed as input.
Comment threadlib/datastore/index.js Outdated

This comment was marked as spam.

This comment was marked as spam.

@silvolu

Copy link
Copy Markdown
ContributorAuthor

@rakyll what about doing it this way?

@rakyll

Copy link
Copy Markdown
Contributor

LGTM

rakyll pushed a commit that referenced this pull request Jul 25, 2014
Return Error object for failed Api requests and fixed flaky test.
@rakyll
rakyll merged commit 61db807 into googleapis:masterJul 25, 2014
sofisl pushed a commit that referenced this pull request Sep 15, 2022
sofisl pushed a commit that referenced this pull request Sep 16, 2022
sofisl pushed a commit that referenced this pull request Sep 27, 2022
* chore: lock files maintenance
* chore: lock files maintenance
sofisl pushed a commit that referenced this pull request Oct 5, 2022
sofisl pushed a commit that referenced this pull request Oct 8, 2022
sofisl pushed a commit that referenced this pull request Oct 11, 2022
* chore: removing node7 job from CircleCI
* chore: rename reference
sofisl pushed a commit that referenced this pull request Oct 13, 2022
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/37f383f8-7560-459e-b66c-def10ff830cb/targets
- [ ] To automatically regenerate this PR, check this box.
Source-Link: googleapis/synthtool@b10590a
sofisl pushed a commit that referenced this pull request Oct 13, 2022
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/c503f640-90ae-4547-bcc8-a154d32c609e/targets
- [ ] To automatically regenerate this PR, check this box.
Source-Link: googleapis/synthtool@15013ef
sofisl pushed a commit that referenced this pull request Oct 13, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@silvolu@rakyll