Skip to content

Exponential backoff and retry certain requests - #468

Merged
stephenplusplus merged 1 commit into
googleapis:masterfrom
ryanseys:rate-limits-RIP
Mar 30, 2015
Merged

Exponential backoff and retry certain requests#468
stephenplusplus merged 1 commit into
googleapis:masterfrom
ryanseys:rate-limits-RIP

Conversation

@ryanseys

Copy link
Copy Markdown
Contributor

This should work. No regression tests because proof it works is our regression tests will no longer suffer from rate limit errors! 🙈

gcloud config now accepts: autoRetry: false (default: true) to turn off and maxRetries: 5 (default: 3) to change number of retries.

All retries are exponentially backed-off. That is:

1st retry: 1000-2000 ms delay
2nd retry: 2000-3000 ms delay
3rd retry: 4000-5000 ms delay (default: this is the last try by default)
4th retry: 8000-9000 ms delay
...

Fixes#460

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2015
@ryanseys

Copy link
Copy Markdown
ContributorAuthor

PS I'm so excited for this! 🍭 🍬 💰

@stephenplusplus

Copy link
Copy Markdown
Contributor

This will go down as one of the best PRs gcloud has ever had.

stephenplusplus added a commit that referenced this pull request Mar 30, 2015
Exponential backoff and retry certain requests
@stephenplusplus
stephenplusplus merged commit eb3a63b into googleapis:masterMar 30, 2015
@ryanseys
ryanseys deleted the rate-limits-RIP branch April 15, 2015 19:57
@sofislsofisl mentioned this pull request Sep 15, 2022
4 tasks
sofisl pushed a commit that referenced this pull request Sep 15, 2022
* chore: migrate to owl bot
* chore: copy files from googleapis-gen fb91803ccef5d7c695139b22788b309e2197856b
* chore: run the post processor
* 🦉 Updates from OwlBot
* chore:add copyright
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Sep 27, 2022
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/4895db2c-aba9-406e-b81d-1e2251ee464c/targets
- [ ] To automatically regenerate this PR, check this box.
Source-Link: googleapis/synthtool@5747555
Source-Link: googleapis/synthtool@bd0deaa
sofisl pushed a commit that referenced this pull request Oct 11, 2022
* Fix docs-samples tests, round 1
* Fix circle.yml
* Add RUN_ALL_BUILDS flag
* More container builder bugfixes
* Tweak env vars + remove manual proxy install
* Env vars in bashrc don't evaluate dynamically, so avoid them
* Add semicolons for command ordering
* Add appengine/static-files test to circle.yaml
* Fix failing container builder tests
* Address comments
sofisl pushed a commit that referenced this pull request Oct 11, 2022
sofisl pushed a commit that referenced this pull request Oct 12, 2022
* Fix docs-samples tests, round 1
* Fix circle.yml
* Add RUN_ALL_BUILDS flag
* More container builder bugfixes
* Tweak env vars + remove manual proxy install
* Env vars in bashrc don't evaluate dynamically, so avoid them
* Add semicolons for command ordering
* Add appengine/static-files test to circle.yaml
* Fix failing container builder tests
* Address comments
sofisl pushed a commit that referenced this pull request Oct 12, 2022
sofisl pushed a commit that referenced this pull request Oct 12, 2022
sofisl pushed a commit that referenced this pull request Oct 13, 2022
* Fix docs-samples tests, round 1
* Fix circle.yml
* Add RUN_ALL_BUILDS flag
* More container builder bugfixes
* Tweak env vars + remove manual proxy install
* Env vars in bashrc don't evaluate dynamically, so avoid them
* Add semicolons for command ordering
* Add appengine/static-files test to circle.yaml
* Fix failing container builder tests
* Address comments
sofisl pushed a commit that referenced this pull request Oct 13, 2022
sofisl pushed a commit that referenced this pull request Nov 9, 2022
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/4895db2c-aba9-406e-b81d-1e2251ee464c/targets
- [ ] To automatically regenerate this PR, check this box.
Source-Link: googleapis/synthtool@5747555
Source-Link: googleapis/synthtool@bd0deaa
sofisl pushed a commit that referenced this pull request Nov 10, 2022
* Fix docs-samples tests, round 1
* Fix circle.yml
* Add RUN_ALL_BUILDS flag
* More container builder bugfixes
* Tweak env vars + remove manual proxy install
* Env vars in bashrc don't evaluate dynamically, so avoid them
* Add semicolons for command ordering
* Add appengine/static-files test to circle.yaml
* Fix failing container builder tests
* Address comments
sofisl pushed a commit that referenced this pull request Nov 10, 2022
sofisl pushed a commit that referenced this pull request Nov 10, 2022
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/f9f34ae0-d83d-4c7a-a197-54a0a7255ebc/targets
- [ ] To automatically regenerate this PR, check this box.
Source-Link: googleapis/synthtool@15013ef
sofisl pushed a commit that referenced this pull request Nov 11, 2022
…ript generator. (#468)
Also removing the explicit generator tag for the IAMPolicy mixin for the kms and pubsub APIS as the generator will now read it from the .yaml file.
PiperOrigin-RevId: 385101839
Source-Link: googleapis/googleapis@80f4042
Source-Link: googleapis/googleapis-gen@d3509d2
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic retry request for all rate limit responses

3 participants

@ryanseys@stephenplusplus@googlebot