Skip to content

feat(storage): expose metadata parameter in asyncio gRPC calls - #17634

Merged
ankitaluthra1 merged 7 commits into
googleapis:mainfrom
ankitaluthra1:main
Aug 6, 2026
Merged

feat(storage): expose metadata parameter in asyncio gRPC calls#17634
ankitaluthra1 merged 7 commits into
googleapis:mainfrom
ankitaluthra1:main

Conversation

@ankitaluthra1

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#17633 🦕

@ankitaluthra1
ankitaluthra1 requested a review from a team as a code ownerJuly 6, 2026 18:14
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@ankitaluthra1

Copy link
Copy Markdown
ContributorAuthor

/gemini review

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces metadata tracking and propagation across several asynchronous components in the Google Cloud Storage library, specifically updating AsyncAppendableObjectWriter, AsyncMultiRangeDownloader, and AsyncGRPCClient to support and persist custom metadata, timeouts, and retries. Corresponding unit tests have been added to verify these behaviors. The review feedback highlights a critical issue in both append() and download_ranges() where custom metadata passed directly to these methods is not persisted to the instance's self.metadata attribute, which would cause stream resumption and retry logic to incorrectly fall back to the older metadata.

@ankitaluthra1

Copy link
Copy Markdown
ContributorAuthor

Waiting on #17616

@parthea

Copy link
Copy Markdown
Contributor

I'm going to add do not merge based on #17634 (comment) (this depends on #17616)

@partheaparthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 13, 2026
@ankitaluthra1ankitaluthra1 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 6, 2026
@ankitaluthra1
ankitaluthra1 enabled auto-merge (squash) August 6, 2026 12:56
@chandra-sirichandra-siri added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2026
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 6, 2026
@ankitaluthra1
ankitaluthra1 merged commit aaa263d into googleapis:mainAug 6, 2026
43 checks passed
@release-pleaserelease-pleaseBot mentioned this pull request Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Expose metadata parameter in Storage asyncio gRPC client methods

4 participants

@ankitaluthra1@parthea@chandra-siri@yoshi-kokoro