Uh oh!
There was an error while loading. Please reload this page.
feat(storage): expose metadata parameter in asyncio gRPC calls - #17634
Conversation
Warning Gemini encountered an error creating the review. You can try again by commenting |
ankitaluthra1
commented
Jul 6, 2026
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces metadata tracking and propagation across several asynchronous components in the Google Cloud Storage library, specifically updating AsyncAppendableObjectWriter, AsyncMultiRangeDownloader, and AsyncGRPCClient to support and persist custom metadata, timeouts, and retries. Corresponding unit tests have been added to verify these behaviors. The review feedback highlights a critical issue in both append() and download_ranges() where custom metadata passed directly to these methods is not persisted to the instance's self.metadata attribute, which would cause stream resumption and retry logic to incorrectly fall back to the older metadata.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ankitaluthra1
commented
Jul 12, 2026
Waiting on #17616 |
parthea
commented
Jul 13, 2026
I'm going to add |
Uh oh!
There was an error while loading. Please reload this page.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes#17633 🦕