Skip to content

fix(storage): fix VERSION fixtures in several tests - #10091

Closed
plamut wants to merge 1 commit into
googleapis:masterfrom
plamut:iss-10090
Closed

fix(storage): fix VERSION fixtures in several tests#10091
plamut wants to merge 1 commit into
googleapis:masterfrom
plamut:iss-10090

Conversation

@plamut

Copy link
Copy Markdown
Contributor

Fixes#10090

A recent change to IAM objects in API core started causing an error if accessing those objects as dicts, if their version is > 1. This commit addresses that by setting the VERSION to 1 in fixtures.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamutplamut added the api: storage Issues related to the Cloud Storage API. label Jan 10, 2020
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020
A recent change to iam objects in API core started causing an error
if accessing those objects as dicts, if their version is > 1. This
commit addresses that by setting the VERSION to 1 in fixtures.
@plamut

Copy link
Copy Markdown
ContributorAuthor

The system tests failure (Python 3.6 only) is caused by the rate limit:

429 ... The project exceeded the rate limit for creating and deleting buckets.

@plamutplamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 10, 2020
@plamut

Copy link
Copy Markdown
ContributorAuthor

Not reproducible anymore on master, thus closing.

@plamutplamut closed this Jan 16, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage: Fix IAM policy versions in unit test fixtures

3 participants

@plamut@googlebot@yoshi-kokoro