fix(resourcemanager): update test assertion and core version pin by plamut · Pull Request #10095 · googleapis/google-cloud-python

plamut · 2020-01-10T15:45:43Z

Towards #10088.

PR checklist

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

This is to assure that Connection object from core supports timeouts.

) * Adjust request params assertion in test (timeout) * Bump pin for core dependency This is to assure that Connection object from core supports timeouts.

plamut added 2 commits January 10, 2020 15:38

Adjust request params assertion in test (timeout)
ac11399

Bump pin for core dependency
c27c0c4
This is to assure that Connection object from core supports timeouts.

plamut added the api: cloudresourcemanager Issues related to the Resource Manager API. label Jan 10, 2020

plamut requested a review from busunkim96 as a code owner January 10, 2020 15:45

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020

busunkim96 approved these changes Jan 10, 2020
View reviewed changes

plamut merged commit 755eb36 into googleapis:masterJan 10, 2020

plamut deleted the fix-tests-resourcemanager branch January 10, 2020 17:57

Navigation Menu

Uh oh!

fix(resourcemanager): update test assertion and core version pin - #10095

fix(resourcemanager): update test assertion and core version pin#10095
plamut merged 2 commits into
googleapis:masterfrom
plamut:fix-tests-resourcemanager

plamut commented Jan 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

plamut commented Jan 10, 2020

PR checklist

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants