Skip to content

fix(dns): update test assertion and core version pins - #10096

Merged
plamut merged 2 commits into
googleapis:masterfrom
plamut:fix-tests-dns
Jan 10, 2020
Merged

fix(dns): update test assertion and core version pins#10096
plamut merged 2 commits into
googleapis:masterfrom
plamut:fix-tests-dns

Conversation

@plamut

Copy link
Copy Markdown
Contributor

Towards #10088.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Version bump is needed, as timeouts were introduced to API core.
@plamutplamut added the api: dns Issues related to the Cloud DNS API. label Jan 10, 2020
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020
@plamut
plamut merged commit 561dced into googleapis:masterJan 10, 2020
@plamut
plamut deleted the fix-tests-dns branch January 10, 2020 17:57
This was referenced Jan 29, 2020
parthea pushed a commit that referenced this pull request Nov 24, 2025
* Adjust request params assertion in test (timeout)
* Update version pin for core dependency
Version bump is needed, as timeouts were introduced to API core.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dnsIssues related to the Cloud DNS API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@plamut@busunkim96@googlebot