Skip to content

feat(spanner): add resource based routing implementation - #10183

Merged
larkee merged 3 commits into
googleapis:masterfrom
larkee:spanner-resource-routing
Jan 31, 2020
Merged

feat(spanner): add resource based routing implementation#10183
larkee merged 3 commits into
googleapis:masterfrom
larkee:spanner-resource-routing

Conversation

@larkee

@larkeelarkee commented Jan 23, 2020

Copy link
Copy Markdown
Contributor

Implement resource based routing.

When creating a SpannerClient, check for suggested endpoints.
If endpoints are returned, use the first one.
If no endpoints are returned, use default endpoint (either global endpoint or user-specified endpoint).

Endpoints are cached per instance on the Client.

This feature is disabled by default and is enabled by setting the environment variable to true.

To enable:
export GOOGLE_CLOUD_SPANNER_ENABLE_RESOURCE_BASED_ROUTING=true

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 23, 2020
@plamutplamut added the api: spanner Issues related to the Spanner API. label Jan 23, 2020
@skuruppu
skuruppu requested a review from rhiroJanuary 28, 2020 01:08
Comment threadspanner/google/cloud/spanner_v1/database.py Outdated
Comment threadspanner/google/cloud/spanner_v1/database.py Outdated
@larkeelarkee changed the title Spanner resource routingfeat(spanner): add resource based routing implementationJan 31, 2020
Add comma to warning message
Co-Authored-By: skuruppu <skuruppu@google.com>
@larkee
larkee merged commit 193a1dd into googleapis:masterJan 31, 2020
This was referenced Jan 31, 2020
This was referenced Feb 2, 2020
parthea pushed a commit that referenced this pull request Mar 9, 2026
* feat(spanner): implement resource routing
* corrected warning message as per the PR comment
* Update spanner/google/cloud/spanner_v1/database.py
Add comma to warning message
Co-Authored-By: skuruppu <skuruppu@google.com>
Co-authored-by: skuruppu <skuruppu@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spannerIssues related to the Spanner API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@larkee@skuruppu@rhiro@plamut@googlebot