Skip to content

feat(core): change default api_request() timeout to non-None - #10219

Merged
plamut merged 1 commit into
googleapis:masterfrom
plamut:iss-10217
Jan 29, 2020
Merged

feat(core): change default api_request() timeout to non-None#10219
plamut merged 1 commit into
googleapis:masterfrom
plamut:iss-10217

Conversation

@plamut

@plamutplamut commented Jan 28, 2020

Copy link
Copy Markdown
Contributor

Closes#10217.

As discussed - we want to have a non-None default timeout, but still allow overriding it with None if somebody wants so.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut
plamut requested a review from crwilcoxJanuary 28, 2020 19:05
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2020
@plamut
plamut merged commit 9ad21f4 into googleapis:masterJan 29, 2020
@plamut
plamut deleted the iss-10217 branch January 29, 2020 07:21
This was referenced Jan 29, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: corecla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Core: change the default timeout of JSONConnection.api_request() to non-None

3 participants

@plamut@busunkim96@googlebot