Uh oh!
There was an error while loading. Please reload this page.
Adding gRPC stubs to Bigtable clients - #1154
Merged
Merged
Conversation
dhermesforce-pushed
the
grpc-stubs-in-client
branch
2 times, most recently
from
September 29, 2015 20:28
e33fe3d to
3e97689Comparedhermes
commented
Sep 29, 2015
ContributorAuthor
@tseaver Rebased on top of `master. PTAL. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermesforce-pushed
the
grpc-stubs-in-client
branch
from
September 30, 2015 02:53
3e97689 to
e68a114Comparedhermes
commented
Oct 1, 2015
ContributorAuthor
@tseaver PTAL. (So you can at least get a feel for how stubs are created and how they work.) |
dhermes
commented
Oct 14, 2015
ContributorAuthor
tseaver
commented
Oct 14, 2015
Contributor
What would be smoothest? I dropped off reviewing this one because it seemed like #1159 was the Right Thing(TM) for dealing with the wonky |
dhermes
commented
Oct 15, 2015
ContributorAuthor
I think #1159 would be smoothest. If we decide NOT to split out into sub-packages then we can revive this. |
2 tasks
dhermes
commented
Nov 15, 2015
ContributorAuthor
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
For now, just adding custom getters which will tell users whether the Client has been started. Commit to add methods to actually make the stubs and start the Client will be forthcoming.
This creates gRPC stubs for talking to each Bigtable service needed by the client.
dhermesforce-pushed
the
grpc-stubs-in-client
branch
from
November 16, 2015 23:10
e68a114 to
32c4c95CompareIn particular, explaining why we __enter__ them but have no corresponding __enter__ for our users.
dhermes
commented
Nov 16, 2015
ContributorAuthor
@tseaver PTAL. I added a comment in the 3rd commit. |
tseaver
commented
Nov 17, 2015
Contributor
LGTM. |
dhermes added a commit
that referenced
this pull request
Nov 17, 2015
Adding gRPC stubs to Bigtable clients
parthea added a commit
that referenced
this pull request
Nov 24, 2025
I've confirmed that the unit tests in python-compute are still passing with this change. Fixes#1154
parthea pushed a commit
that referenced
this pull request
Nov 24, 2025
Source-Link: googleapis/synthtool@bd9ede2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:04c35dc5f49f0f503a306397d6d043685f8d2bb822ab515818c4208d7fb2db3a Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Sweña (Swast) <swast@google.com>
parthea added a commit
that referenced
this pull request
Mar 2, 2026
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: mukund-ananthu <83691193+mukund-ananthu@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Uses #1153 as diffbase