Uh oh!
There was an error while loading. Please reload this page.
Speling: pass 'ack_deadline' as 'ackDeadlineSeconds' everywhere. - #1182
Conversation
dhermes
commented
Oct 14, 2015
Can you update the system tests to avoid this issue coming up again? Also, can you link to a doc describing this parameter. |
tseaver
commented
Oct 14, 2015
I guess I could: we don't have anything like exhaustive coverage in the system tests, though.
(note the irony that the ID for the table cell is closer to our spelling than to the one used in the actual API). |
dhermes
commented
Oct 14, 2015
I think the reason our system tests were ever named regression tests was for reasons like the very bug that caused this. Let's add one to make sure it doesn't come back. How could we be more comprehensive? Should we? |
tseaver
commented
Oct 15, 2015
543caaf adds that test.
Dunno: for instance, the other optional parameter to |
dhermes
commented
Oct 15, 2015
Great! LGTM (We have similar issues with Bigtable) |
…_json_payload Speling: pass 'ack_deadline' as 'ackDeadlineSeconds' everywhere.
#1182) * fix: udpated the lower bound of interactive timeout and fix the kwargs invalid syntax * update token * update token * prohibit the access from constructor and only allow the injection and test * fix lint * adding interactive timeout validation test * update token
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore(main): release 3.49.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
May fix#1169.