Skip to content

Strip excess custom exceptions from 'gcloud.streaming' - #1232

Merged
tseaver merged 7 commits into
googleapis:masterfrom
tseaver:1227-streaming-strip_excess_custom_exceptions
Nov 19, 2015
Merged

Strip excess custom exceptions from 'gcloud.streaming'#1232
tseaver merged 7 commits into
googleapis:masterfrom
tseaver:1227-streaming-strip_excess_custom_exceptions

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Closes#1227

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2015
Comment threadgcloud/streaming/transfer.py Outdated

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes

Copy link
Copy Markdown
Contributor

This doesn't "move the remainder to gcloud.exceptions" as the bug says will happen.

@tseaver

Copy link
Copy Markdown
ContributorAuthor

The residue are all tangled up with fixing #1223. If there are any left after that one, then they can move.

@dhermes

Copy link
Copy Markdown
Contributor

I suggest filing another bug then (or leaving that one open and renaming it) so it doesn't slip our minds.

@tseaver

Copy link
Copy Markdown
ContributorAuthor

#1234 captures the final cleanup.

@dhermes

Copy link
Copy Markdown
Contributor

Good deal

Allow 'natural' OSError to propagate.
Addresses:
#1232 (comment)
@dhermes

Copy link
Copy Markdown
Contributor

LGTM pending Travis

tseaver added a commit that referenced this pull request Nov 19, 2015
…tom_exceptions
Strip excess custom exceptions from 'gcloud.streaming'
@tseaver
tseaver merged commit cec15ac into googleapis:masterNov 19, 2015
@tseaver
tseaver deleted the 1227-streaming-strip_excess_custom_exceptions branch November 19, 2015 23:11
@dhermesdhermes mentioned this pull request Jan 25, 2016
parthea pushed a commit that referenced this pull request Nov 24, 2025
🤖 I have created a release *beep* *boop*
---
### [0.63.7](googleapis/gapic-generator-python@v0.63.6...v0.63.7) (2022-03-08)
### Bug Fixes
* resolve issue where rest transport is not used in certain tests ([#1231](googleapis/gapic-generator-python#1231)) ([90ab41a](googleapis/gapic-generator-python@90ab41a))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea added a commit that referenced this pull request Mar 6, 2026
* chore: use gapic-generator-python 0.65.2
PiperOrigin-RevId: 444333013
Source-Link: googleapis/googleapis@f91b6cf
Source-Link: googleapis/googleapis-gen@16eb360
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZlYjM2MDk1YzI5NGU3MTJjNzRhMWJmMjM1NTA4MTdiNDIxNzRlNSJ9
* update owlbot.py to pull in changes from gapic generator
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot