Skip to content

Returning ints from BigQuery Table.num_rows/num_bytes. - #1252

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:bigquery-int-values
Dec 1, 2015
Merged

Returning ints from BigQuery Table.num_rows/num_bytes.#1252
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:bigquery-int-values

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Also fixing Table.expires docstring typo.

@dhermesdhermes added the api: bigquery Issues related to the BigQuery API. label Nov 30, 2015
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2015
@tseaver

Copy link
Copy Markdown
Contributor

Do we need to add / update tests exercising the int conversion?

@dhermes

Copy link
Copy Markdown
ContributorAuthor

Good call. I was peeling off my notes robotically and it didn't occur to me.

Also fixing Table.expires docstring typo.
@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver Rebased and added two tests. They are a bit over-loaded: in reality they each contain 4 itty bitty tests.

@tseaver

Copy link
Copy Markdown
Contributor

LGTM

dhermes added a commit that referenced this pull request Dec 1, 2015
Returning ints from BigQuery Table.num_rows/num_bytes.
@dhermes
dhermes merged commit a7b395a into googleapis:masterDec 1, 2015
@dhermes
dhermes deleted the bigquery-int-values branch December 1, 2015 02:12
@dhermesdhermes mentioned this pull request Jan 25, 2016
parthea pushed a commit that referenced this pull request Mar 9, 2026
* test: add mock server tests
* chore: move to testing folder + fix formatting
* refactor: move mock server tests to separate directory
* feat: add database admin service
Adds a DatabaseAdminService to the mock server and sets up a basic
test case for this.
Also removes the generated stubs in the grpc files, as these are
not needed.
* test: add DDL test
* test: add async client tests
* chore: remove async + add transaction handling
* chore: cleanup
* perf: remove repeated GetSession calls for FixedSizePool
Add a _last_use_time to Session and use this to determine whether the
FixedSizePool should check whether the session still exists, and whether
it should be replaced. This significantly reduces the number of times that
GetSession is called when using FixedSizePool.
* chore: run code formatter
* chore: revert to utcnow()
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* fix: update _last_use_time in trace_call
* chore: fix formatting
* fix: remove unnecessary update of _last_use_time
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot