Skip to content

Removing datastore Batch.add_auto_id_entity. - #1296

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:remove-datastore-add-auto-id
Dec 17, 2015
Merged

Removing datastore Batch.add_auto_id_entity.#1296
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:remove-datastore-add-auto-id

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

This mutation type has been removed in v1beta3 so we
just use Batch.put() to handle the previous duty.

Also simplifying the helper which populates a protobuf entity
from a gcloud-python Entity.

@dhermesdhermes added the api: datastore Issues related to the Datastore API. label Dec 17, 2015
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2015
@dhermesdhermes mentioned this pull request Dec 17, 2015
49 tasks
@tseaver

Copy link
Copy Markdown
Contributor

LGTM, modulo conflicts.

This mutation type has been removed in v1beta3 so we
just use Batch.put() to handle the previous duty.
Also simplifying the helper which populates a protobuf entity
from a gcloud-python Entity.
@dhermes
dhermesforce-pushed the remove-datastore-add-auto-id branch from 0ff93cb to 3ec13caCompareDecember 17, 2015 16:59
dhermes added a commit that referenced this pull request Dec 17, 2015
@dhermes
dhermes merged commit 8b09538 into googleapis:masterDec 17, 2015
@dhermes
dhermes deleted the remove-datastore-add-auto-id branch December 17, 2015 17:05
@dhermesdhermes mentioned this pull request Jan 25, 2016
parthea pushed a commit that referenced this pull request Nov 26, 2025
* feat: expose for external account creds
* add universe_domain as info property
* fix info error
* adding coverage of explicit universe_domain assigning
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot