Skip to content

Adding GC Rule to Bigtable Column Family class. - #1302

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:bigtable-col-fam-w-gc-rule
Dec 17, 2015
Merged

Adding GC Rule to Bigtable Column Family class.#1302
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:bigtable-col-fam-w-gc-rule

Conversation

@dhermes

@dhermesdhermes commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

Also adding equality check for column family
instances.

@dhermes
Adding GC Rule to Bigtable Column Family class.
9b296c9
Also adding equality check for column family
instances.
@dhermesdhermes added the api: bigtable Issues related to the Bigtable API. label Dec 17, 2015
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 17, 2015
tseaver
tseaver reviewed Dec 17, 2015
View reviewed changes
Comment threadgcloud/bigtable/column_family.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver

tseaver commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

LGTM. Maybe we can revisit pulling out the __ne__s later/

dhermes added a commit that referenced this pull request Dec 17, 2015
@dhermes
Merge pull request#1302from dhermes/bigtable-col-fam-w-gc-rule
ae01c3a
Adding GC Rule to Bigtable Column Family class.
@dhermes
dhermes merged commit ae01c3a into googleapis:masterDec 17, 2015
@dhermes
dhermes deleted the bigtable-col-fam-w-gc-rule branch December 17, 2015 19:32
@dhermes

dhermes commented Dec 17, 2015

Copy link
Copy Markdown
ContributorAuthor

You're reviewing faster than I can get them out! I'm trying to balance this and grading a final exam, and you're winning.

Care to take a look at #1241 (mine) and #1274 (a very important fix in light of #1214)?

@tseaver

tseaver commented Dec 17, 2015

Copy link
Copy Markdown
Contributor

No worries. I've got to get my Table.upload_from_file finished.

I'll try to look again at #1241: I had the impression that it was "not ready for prime time."

#1274 worries me.

@dhermes

dhermes commented Dec 17, 2015

Copy link
Copy Markdown
ContributorAuthor

#1241 is ready for prime time, I am working on getting it merge-able right now (done, if tests pass).

#1274 worries me too, but so does #1214. Let's continue the discussion in one of those places?

@dhermesdhermes mentioned this pull request Jan 25, 2016
Merged
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea@gcf-owl-bot
ci: use python 3.8 in docs build (#1302)
bc24d3d
* ci: use python 3.8 in docs build
* add files required for docs build
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* update docs link
* remove docfx session from publish-docs.sh
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 2, 2026
@mukund-ananthu
fix: Add support for Python3.13 (#1302)
43936be
parthea pushed a commit that referenced this pull request Mar 9, 2026
@lszinv@rahul2393
feat: Add Attempt, Operation and GFE Metrics (#1302)
8d9097f
* Feat: Added Metric Interceptor integration with Attempt metrics
* Feat: Added Operation and GFE Metrics
* Removed warning from GCP Resource Detector
* Added Attempt failure test
* Moved MetricCapture out of Tracer logic
* Adjustments to handle-disabled behaviour of MetricsCapture
* Added higher-level short circuiting of metric logic when disabled
---------
Co-authored-by: rahul2393 <irahul@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot