Uh oh!
There was an error while loading. Please reload this page.
Fixing some docstrings that did not render as intended - #1345
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermesforce-pushed
the
some-docs-cleanup
branch
from
January 7, 2016 21:35
fa6429b to
51c7b41Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermes
commented
Jan 7, 2016
ContributorAuthor
@tseaver PTAL I added |
tseaver
commented
Jan 7, 2016
Contributor
While I understand the desire for "pretty" history, this PR is a case where rebasing to squash commits interferes with review: the small changes you just introduced would've been easier to re-review as separate commits. LGTM |
dhermes
commented
Jan 7, 2016
ContributorAuthor
Gotcher. In |
Sphinx successfully rendered some docstrings that did things different than intended. Found via visual inspection of a few of the rendered files (more to come). Also - using names of basic types (`dict` instead of `dictionary`, `bool` instead of `boolean`) since Sphinx recognizes them. - fixing some broken Sphinx links - fixing some broken URLs (404, docs moved) - adding formatting to unformatted text - renaming doc with underscores to use hyphen - removing an accidentally public var that was documented (eklass -> _eklass) - referring to `gcloud` module instead of `gcloud.storage` in `gcloud.exceptions`
dhermesforce-pushed
the
some-docs-cleanup
branch
from
January 7, 2016 22:59
51c7b41 to
c684c29Comparedhermes added a commit
that referenced
this pull request
Jan 7, 2016
Fixing some docstrings that did not render as intended
parthea pushed a commit
that referenced
this pull request
Mar 9, 2026
Source-Link: googleapis/synthtool@71a7297 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e8dcfd7cbfd8beac3a3ff8d3f3185287ea0625d859168cc80faccfc9a7a00455 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: cojenco <cathyo@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sphinx successfully rendered some docstrings that did things
different than intended. Found via visual inspection of a few
of the rendered files (more to come). Also
dictinstead ofdictionary,boolinstead ofboolean) since Sphinx recognizes them.