Skip to content

Renaming path_element->path in Key. - #1360

Closed
dhermes wants to merge 1 commit into
googleapis:masterfrom
dhermes:rename-path-element-1288
Closed

Renaming path_element->path in Key.#1360
dhermes wants to merge 1 commit into
googleapis:masterfrom
dhermes:rename-path-element-1288

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Can't be merged until v1beta3 is released.

As with #1359, relies on #1329 being merged, I just used _has_field even though it hadn't been implemented yet since I knew the tests would fail anyway.

@dhermesdhermes added api: datastore Issues related to the Datastore API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jan 7, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2016
@dhermesdhermes mentioned this pull request Jan 7, 2016
49 tasks
@dhermes
dhermesforce-pushed the rename-path-element-1288 branch from 20931bf to 49fce26CompareJanuary 15, 2016 06:45
@dhermes
dhermesforce-pushed the rename-path-element-1288 branch from 49fce26 to 771e710CompareJanuary 21, 2016 00:33
@dhermesdhermes closed this Feb 12, 2016
@dhermes
dhermes deleted the rename-path-element-1288 branch February 12, 2016 22:46
parthea pushed a commit that referenced this pull request Nov 24, 2025
…1360)
These changes allow running the generated python gapic unit tests on the fly by bazel right after generation in our CI.
As a result of this change some of the issues with the generated code became immediatelly visible (because now we ran the generated tests) and will be addressed separately in these issues:
googleapis/gapic-generator-python#1358googleapis/gapic-generator-python#1359
The tests can be now added in BUILD.bazel files as follows:
```bzl
py_test(
name = "credentials_py_gapic_test",
srcs = [
"credentials_py_gapic_pytest.py",
"credentials_py_gapic_test.py",
],
legacy_create_init = False,
deps = [
":credentials_py_gapic",
],
)
```
parthea added a commit that referenced this pull request Mar 6, 2026
* chore(deps): update all dependencies
* revert
* revert
* pin matplotlib for py37
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dhermes@googlebot