Skip to content

Moving _pb_timestamp_to_datetime into core. - #1361

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:move-_pb_timestamp_to_datetime
Jan 15, 2016
Merged

Moving _pb_timestamp_to_datetime into core.#1361
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:move-_pb_timestamp_to_datetime

Conversation

@dhermes

@dhermesdhermes commented Jan 7, 2016

Copy link
Copy Markdown
Contributor

This is in advance of v1beta3, where it will be needed to parse Value.timestamp_value (which is of type timestamp_pb2.Timestamp). Also adding _datetime_to_pb_timestamp for the other direction.

NOTE: Has #1353 as diffbase.

@dhermesdhermes added api: datastore Issues related to the Datastore API. api: core api: bigtable Issues related to the Bigtable API. labels Jan 7, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2016
@dhermesdhermes mentioned this pull request Jan 7, 2016
Closed
49 tasks
@tseaver

tseaver commented Jan 14, 2016

Copy link
Copy Markdown
Contributor

Rather than copying the generated files into our own package here, it might be good to generate all the proto-based files for BigTable in a separate package, and just import them like the ones from protobuf and googleapis-common-protos.

@dhermes

dhermes commented Jan 14, 2016

Copy link
Copy Markdown
ContributorAuthor

I agree and it's something that's been discussed with @tbetbetbe but I don't think it's worth blocking this PR. WDYT?

@tseaver

tseaver commented Jan 14, 2016

Copy link
Copy Markdown
Contributor

I'm actually thinking it would be better than what I proposed in #1317: if we could work out generating releasing the Python code from the protos as a separate project, we would simplify our own bits here, and maybe get to piggyback stuff like the Makefile in googleapis (note that it doesn't seem to support Python, so I'm not sure how they are generating googleapis-common-protos).

@dhermes
dhermesforce-pushed the move-_pb_timestamp_to_datetime branch 2 times, most recently from be6e3bb to e0f0c60CompareJanuary 14, 2016 23:24
@dhermes
Moving _pb_timestamp_to_datetime into core.
d3058f3
This is in advance of `v1beta3`, where it will be needed
to parse `Value.timestamp_value` (which is of type
`timestamp_pb2.Timestamp`). Also adding `_datetime_to_pb_timestamp`
for the other direction.
@dhermes
dhermesforce-pushed the move-_pb_timestamp_to_datetime branch from e0f0c60 to d3058f3CompareJanuary 15, 2016 02:28
@dhermes

dhermes commented Jan 15, 2016

Copy link
Copy Markdown
ContributorAuthor

@tseaver PTAL, I rebased after #1353

@tseaver

tseaver commented Jan 15, 2016

Copy link
Copy Markdown
Contributor

LGTM

dhermes added a commit that referenced this pull request Jan 15, 2016
@dhermes
Merge pull request#1361from dhermes/move-_pb_timestamp_to_datetime
1e70cbf
Moving _pb_timestamp_to_datetime into core.
@dhermes
dhermes merged commit 1e70cbf into googleapis:masterJan 15, 2016
@dhermes
dhermes deleted the move-_pb_timestamp_to_datetime branch January 15, 2016 04:54
@dhermesdhermes mentioned this pull request Jan 25, 2016
Merged
atulep pushed a commit that referenced this pull request Apr 6, 2023
@dizcology@busunkim96
Speech model selection [(#1361)](GoogleCloudPlatform/python-docs-samp…
4f52fe5
…les#1361)
* add transcribe_model_selection
* add transcribe_model_selection_test
* flake
atulep pushed a commit that referenced this pull request Apr 6, 2023
@dizcology@busunkim96
Speech model selection [(#1361)](GoogleCloudPlatform/python-docs-samp…
d0bb743
…les#1361)
* add transcribe_model_selection
* add transcribe_model_selection_test
* flake
atulep pushed a commit that referenced this pull request Apr 18, 2023
@dizcology@busunkim96
Speech model selection [(#1361)](GoogleCloudPlatform/python-docs-samp…
bf55a12
…les#1361)
* add transcribe_model_selection
* add transcribe_model_selection_test
* flake
parthea pushed a commit that referenced this pull request Oct 22, 2023
@dizcology@busunkim96
Speech model selection [(#1361)](GoogleCloudPlatform/python-docs-samp…
88df78c
…les#1361)
* add transcribe_model_selection
* add transcribe_model_selection_test
* flake
parthea pushed a commit that referenced this pull request Mar 6, 2026
@renovate-bot
chore(deps): update dependency db-dtypes to v1.0.4 (#1361)
8877452
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigtableIssues related to the Bigtable API.api: coreapi: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot