Skip to content

Treating DNS zone creation time as an RFC 3339 string. - #1368

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:fix-1362
Jan 14, 2016
Merged

Treating DNS zone creation time as an RFC 3339 string. #1368
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:fix-1362

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Was previously assumed to be a float (seconds from the epoch). Also using core timestamp utilities in dns tests.

Fixes#1362.


@kvdb I found I couldn't even create a managed zone to test if this was possible. How did you create your pre-existing zones? (I'm curious if you have a test domain or if you are actually using the service to manage DNS rules for a live domain.)

Was previously assumed to be a float (seconds from the epoch). Also
using core timestamp utilities in `dns` tests.
Fixesgoogleapis#1362.
@dhermesdhermes added the api: dns Issues related to the Cloud DNS API. label Jan 8, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2016
@kvdb

kvdb commented Jan 11, 2016

Copy link
Copy Markdown

@dhermes I added the zone using the developer console. For now, I only have a need to use the gcloud library for updating existing records. Thanks for the fast response!

@tseaver

Copy link
Copy Markdown
Contributor

LGTM

dhermes added a commit that referenced this pull request Jan 14, 2016
Treating DNS zone creation time as an RFC 3339 string.
@dhermes
dhermes merged commit 0f2b969 into googleapis:masterJan 14, 2016
@dhermes
dhermes deleted the fix-1362 branch January 14, 2016 20:55
@dhermesdhermes mentioned this pull request Jan 25, 2016
parthea pushed a commit that referenced this pull request Nov 26, 2025
feat: Add optional non blocking refresh for sync auth code
parthea added a commit that referenced this pull request Mar 2, 2026
parthea pushed a commit that referenced this pull request Mar 9, 2026
* fix: pass through kwargs in dbapi connect
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dnsIssues related to the Cloud DNS API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@kvdb@tseaver@googlebot