Skip to content

Updating datastore system test to allow concurrent runs. - #1370

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:ds-system-test-namespace
Jan 14, 2016
Merged

Updating datastore system test to allow concurrent runs.#1370
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:ds-system-test-namespace

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Using a namespace for any key which is changed (inserted/deleted) so that concurrent tests don't operate on the same data. The one exception is TestDatastoreQuery which depends on entities which need to be already stored and indexed before running. For this test case, a new client is created without any namespace.

NOTE: Has #1369 as diffbase.

Inspired by #1363.

@dhermesdhermes added api: datastore Issues related to the Datastore API. testing labels Jan 8, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2016
@dhermes
dhermesforce-pushed the ds-system-test-namespace branch from 88abb42 to 4d5b224CompareJanuary 8, 2016 21:34
Comment threadsystem_tests/datastore.py Outdated

This comment was marked as spam.

This comment was marked as spam.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver FYI #1383 should be merged before this.

@dhermes
dhermesforce-pushed the ds-system-test-namespace branch 2 times, most recently from 4cbeada to 49f8a23CompareJanuary 14, 2016 21:13
@dhermes

Copy link
Copy Markdown
ContributorAuthor

LuLz. Pushed a test key.

Using a namespace for any key which is changed (inserted/deleted)
so that concurrent tests don't operate on the same data. The
one exception is `TestDatastoreQuery` which depends on entities
which need to be already stored and indexed before running. For
this test case, a new client is created without any namespace.
@dhermes
dhermesforce-pushed the ds-system-test-namespace branch from 49f8a23 to 6d85a03CompareJanuary 14, 2016 21:15

This comment was marked as spam.

This comment was marked as spam.

dhermes added a commit that referenced this pull request Jan 14, 2016
Updating datastore system test to allow concurrent runs.
@dhermes
dhermes merged commit aca137f into googleapis:masterJan 14, 2016
@dhermes
dhermes deleted the ds-system-test-namespace branch January 14, 2016 21:28
@dhermesdhermes mentioned this pull request Jan 25, 2016
parthea pushed a commit that referenced this pull request Mar 9, 2026
* build: reduce build time
* build: move some checks to GitHub Actions
* test: speed up more tests
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot