Uh oh!
There was an error while loading. Please reload this page.
Adding check that all public modules are documented. - #1375
Conversation
3adfee2 to
8caffb9Comparedhermes
commented
Jan 15, 2016
@tseaver PTAL |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
8caffb9 to
8285be2Comparedhermes
commented
Jan 20, 2016
@tseaver PTAL. This time At this point we should discuss which need to be actually documented and which I should add to When running locally, the errors are: |
dhermes
commented
Jan 28, 2016
@tseaver PTAL |
8285be2 to
c04d18dComparetseaver
commented
Jan 29, 2016
LGTM |
dhermes
commented
Jan 29, 2016
@tseaver There are still questions to resolve. We have several undocumented modules and need to decide which ones to ignore and which ones need documenting. I expected the CI to fail but |
dhermes
commented
Feb 3, 2016
@tseaver PTAL, pending question above |
- Removing accidentally including bigquery module from IGNORED_MODULES in verify_include_modules - Adding Sphinx as a lint dependency (it couldn't be imported) - Fixing Python 2 style print statements in run_pylint
c04d18d to
722d6abCompareAlso making sure `tox -e docs` **always** gets run in update_docs.sh, to verify the docs build successfully at all times.
722d6ab to
27da413Comparetheacodes
commented
Feb 12, 2016
I think we should ignore:
But we should probably document all of these:
|
dhermes
commented
Feb 12, 2016
Everything except |
theacodes
commented
Feb 12, 2016
Cool, LGTM. |
Adding check that all public modules are documented.
The global variable [`_DEFAULT_TOKEN_LIFETIME_SECS`](https://togithub.com/googleapis/google-auth-library-python/blob/main/google/auth/impersonated_credentials.py#L40-L61) is set twice. Can we get rid of this duplicate?
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Fixes#714.
Also: making prints to
stderrPython 3 friendly inrun_pylint.py.@tseaver Note the
docsrule will fail here. This was intentional. I wanted to display which modules were still undocumented so we could discuss if they should be added to theIGNORED_MODULESset or if we should add them to anrstfile.