Skip to content

Allowing datastore system test to run on emulator with no connection. - #1386

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:ds-emulator-no-internet
Jan 15, 2016
Merged

Allowing datastore system test to run on emulator with no connection.#1386
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:ds-emulator-no-internet

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Currently, the GOOGLE_APPLICATION_CREDENTIALS is used and an access token is minted even though requests to the emulator require no authentication.

Currently, the GOOGLE_APPLICATION_CREDENTIALS is used and an access
token is minted even though requests to the emulator require no
authentication.
@dhermesdhermes added api: datastore Issues related to the Datastore API. testing labels Jan 15, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2016
@dhermes

Copy link
Copy Markdown
ContributorAuthor

By allowing the default behavior to occur, an authorized http instance tries to [get a new] access token even if it doesn't need one.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@pcostell Is it intended that the emulator doesn't check the value of the Authorization header (or even if the header has been sent)?

@tseaver

Copy link
Copy Markdown
Contributor

LGTM

dhermes added a commit that referenced this pull request Jan 15, 2016
Allowing datastore system test to run on emulator with no connection.
@dhermes
dhermes merged commit 0b602ea into googleapis:masterJan 15, 2016
@dhermes
dhermes deleted the ds-emulator-no-internet branch January 15, 2016 16:33
@dhermesdhermes mentioned this pull request Jan 25, 2016
parthea pushed a commit that referenced this pull request Nov 26, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 2, 2026
Co-authored-by: mukund-ananthu <83691193+mukund-ananthu@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
parthea pushed a commit that referenced this pull request Mar 9, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot