Skip to content

Making emulator scripts wait until emulators are ready. - #1417

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:emulator-less-flaky
Jan 28, 2016
Merged

Making emulator scripts wait until emulators are ready.#1417
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:emulator-less-flaky

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Also manually handling clean-up of child processes spawned. The gcloud tool was orphan-ing some processes.


NOTE: Has #1400 as diffbase.

Filed googleapis/google-cloud-datastore#87 in response to orphan-ed processes.

@dhermesdhermes added api: datastore Issues related to the Datastore API. testing api: pubsub Issues related to the Pub/Sub API. labels Jan 25, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 25, 2016
@dhermes

Copy link
Copy Markdown
ContributorAuthor

Another option would be to create a process group before calling subprocess, but I haven't tried to implement, so I'm not sure it'll work.

@dhermes
dhermesforce-pushed the emulator-less-flaky branch 2 times, most recently from 1de9aaf to 31e6643CompareJanuary 27, 2016 03:36
@dhermes
dhermesforce-pushed the emulator-less-flaky branch 2 times, most recently from cb8697f to 034d83fCompareJanuary 28, 2016 19:52
Also manually handling clean-up of child processes spawned.
The ``gcloud`` tool was orphan-ing some processes.
dhermes added a commit that referenced this pull request Jan 28, 2016
Making emulator scripts wait until emulators are ready.
@dhermes
dhermes merged commit 2911bd9 into googleapis:masterJan 28, 2016
@dhermes
dhermes deleted the emulator-less-flaky branch January 28, 2016 20:34
@dhermesdhermes mentioned this pull request Jan 29, 2016
parthea added a commit that referenced this pull request Nov 24, 2025
* add generated sample comment
* update golden files
* update tests/unit/samplegen/golden_snippets
* update tests/snippetgen/goldens
* update tests/integration/goldens/eventarc/samples/generated_samples
* update golden clients and metadata
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dhermes@googlebot