Skip to content

Adding key_filter to datastore Query. - #1433

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:fix-1432
Jan 30, 2016
Merged

Adding key_filter to datastore Query.#1433
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:fix-1432

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Also updating system tests and system test helpers to avoid direct use of __key__.

Fixes#1432.

Also updating system tests and system test helpers to
avoid direct use of __key__.
Fixesgoogleapis#1432.
@dhermesdhermes added the api: datastore Issues related to the Datastore API. label Jan 30, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2016
They were using the dataset ID environment variable key rather
than the value.
@dhermes

Copy link
Copy Markdown
ContributorAuthor

Also fixed the broken clear_datastore.py and populate_datastore.py helper. I broke them in #1383#1369

@tseaver

Copy link
Copy Markdown
Contributor

LGTM. Are we not-yet-ready-for-primetime on AppVeyor?

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver I commented on #1318, it introduced a test that fails on Windows. Just filed #1434 about it.

I'd like to turn off AppVeyor for PRs though.

dhermes added a commit that referenced this pull request Jan 30, 2016
Adding key_filter to datastore Query.
@dhermes
dhermes merged commit 0910f99 into googleapis:masterJan 30, 2016
@dhermes
dhermes deleted the fix-1432 branch January 30, 2016 19:13
@dhermesdhermes mentioned this pull request Feb 17, 2016
parthea added a commit that referenced this pull request Nov 24, 2025
This does:
1) fixes LRO method mock value which for watever reason worked under proto 3.x.x (cpp implementaiton) but does not work under proto 4
2) Add `NO COVER` to mock imports in tests as those lines are mutually exclusive depending on the python version it is runniin gunder.
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot