Skip to content

Adding Bigtable Cell class. - #1473

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:bigtable-cell
Feb 16, 2016
Merged

Adding Bigtable Cell class.#1473
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:bigtable-cell

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Used to hold data in rows retrieved.

@tseaver This module could definitely use some design review (none of the content here yet, but worth discussing now or at least thinking about).

Right now, the implementation is as follows:

  • Rows are read from a Table (and a Cell is like a "column" in a row, so there can be many), so the helpers needed to parse a row that was read are in row_data.py
  • Mutations (in rows) are created directly on a Row, and this is all done in row.py (all code submitted or merged)

Used to held data in rows retrieved.
@dhermesdhermes added the api: bigtable Issues related to the Bigtable API. label Feb 15, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2016
@tseaver

Copy link
Copy Markdown
Contributor

Travis failed on the docs build:

Found undocumented public modules:
- gcloud.bigtable.row_data
ERROR: InvocationError: '/home/travis/build/GoogleCloudPlatform/gcloud-python/.tox/docs/bin/python /home/travis/build/GoogleCloudPlatform/gcloud-python/scripts/verify_included_modules.py'

@tseaver

Copy link
Copy Markdown
Contributor

No explicit tests for the Cell class' methods?

@dhermes

Copy link
Copy Markdown
ContributorAuthor

Double fail. Sorry, forgot to stage it. Must've been in a hurry.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver PTAL.

Still would like to know what you think about having row.py and row_data.py separately.

@tseaver

Copy link
Copy Markdown
Contributor

Still would like to know what you think about having row.py and row_data.py separately.

My only quibble is with the filename: given that the module just contains the Cell class, ISTM that it would most logically be named gcloud.bigtable.cell.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver

Copy link
Copy Markdown
Contributor

Cell is just the beginning:

SGTM

@dhermes

Copy link
Copy Markdown
ContributorAuthor

And the content of this commit?

@tseaver

Copy link
Copy Markdown
Contributor

Fine to merge.

dhermes added a commit that referenced this pull request Feb 16, 2016
@dhermes
dhermes merged commit 180db64 into googleapis:masterFeb 16, 2016
@dhermes
dhermes deleted the bigtable-cell branch February 16, 2016 01:56
@dhermesdhermes mentioned this pull request Feb 17, 2016
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
Snippet shows how to set the read lock mode at the client-level and how
to override the option at the transaction-level.
parthea pushed a commit that referenced this pull request Mar 9, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.
Librarian Version: v1.0.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209
<details><summary>google-cloud-spanner: 3.63.0</summary>
##
[3.63.0](googleapis/python-spanner@v3.62.0...v3.63.0)
(2026-02-13)
### Features
* add requestID info in error exceptions (#1415)
([2c5eb96c](googleapis/python-spanner@2c5eb96c))
### Bug Fixes
* prevent thread leak by ensuring singleton initialization (#1492)
([e792136a](googleapis/python-spanner@e792136a))
### Documentation
* snippet for setting read lock mode (#1473)
([7e79920c](googleapis/python-spanner@7e79920c))
</details>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot