Skip to content

Harden 'Message.from_api_repr' against missing 'data' - #1481

Merged
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:1480-pubsub-empty_payload-missing_data
Feb 17, 2016
Merged

Harden 'Message.from_api_repr' against missing 'data'#1481
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:1480-pubsub-empty_payload-missing_data

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

e2b3ef7 also cleans up the order of testcase methods to match the actual order of Message methods.

Closes#1480

@tseavertseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: pubsub Issues related to the Pub/Sub API. labels Feb 17, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 17, 2016
@dhermes

Copy link
Copy Markdown
Contributor

@tseaver Can you rebase since #1479 is in now?

@dhermes

Copy link
Copy Markdown
Contributor

LGTM pending rebase / Travis

tseaver added a commit that referenced this pull request Feb 17, 2016
…ng_data
Harden 'Message.from_api_repr' against missing 'data'
@tseaver
tseaver merged commit 87c7a4c into googleapis:masterFeb 17, 2016
@tseaver
tseaver deleted the 1480-pubsub-empty_payload-missing_data branch February 17, 2016 16:50
@dhermesdhermes mentioned this pull request Feb 17, 2016
parthea pushed a commit that referenced this pull request Mar 6, 2026
* chore: delete duplicate code from snippets.py
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
Co-authored-by: cojenco <cathyo@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot