Skip to content

Implementing consume_*() methods on Bigtable PartialRowsData. - #1493

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:bigtable-complete-partial-rows-data
Feb 18, 2016
Merged

Implementing consume_*() methods on Bigtable PartialRowsData.#1493
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:bigtable-complete-partial-rows-data

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

These methods read from a stream of ReadRowsResponse's, parse them and then store them on the PartialRowsData instance.

@tseaver The implementation of PartialRowData.update_from_read_rows is coming soon. It depends on #1492. I held off on including it there because it has a non-trivial amount of code.

@dhermesdhermes added the api: bigtable Issues related to the Bigtable API. label Feb 18, 2016
@dhermesdhermes self-assigned this Feb 18, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 18, 2016
always
"""
raise NotImplementedError

This comment was marked as spam.

This comment was marked as spam.

These methods read from a stream of ReadRowsResponse's,
parse them and then store them on the PartialRowsData
instance.
@dhermes
dhermesforce-pushed the bigtable-complete-partial-rows-data branch from 659e34c to 3d98eb7CompareFebruary 18, 2016 20:42
@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver PTAL (I rebased on top of #1494)

@tseaver

Copy link
Copy Markdown
Contributor

LGTM after the rebase/Travis.

dhermes added a commit that referenced this pull request Feb 18, 2016
…data
Implementing consume_*() methods on Bigtable PartialRowsData.
@dhermes
dhermes merged commit 14263ee into googleapis:masterFeb 18, 2016
@dhermes
dhermes deleted the bigtable-complete-partial-rows-data branch February 18, 2016 20:49
@dhermesdhermes mentioned this pull request Feb 20, 2016
parthea pushed a commit that referenced this pull request Apr 1, 2026
* chore: skip the small udf tests from system and coverage tests
* store pytest.mark.skipif in a variable
* name `pytestmark` to trigger module level pytest.mark.skipif
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot