Skip to content

chore: librarian generate pull request: 20251212T192037Z#14964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 3 commits into from
Dec 12, 2025
Merged

chore: librarian generate pull request: 20251212T192037Z #14964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47e5526
chore: temporarily allow docs warnings for google-shopping-merchant-a…
parthea Dec 12, 2025
44fb259
feat: generate libraries
parthea Dec 12, 2025
f8b03a3
Update .librarian/generator-input/client-post-processing/allow-docs-w…
parthea Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ...put/client-post-processing/allow-docs-warnings-for-google-shopping-merchant-accounts.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
# Copyright 2025 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
description: Allow documentation warnings for google-shopping-merchant-accounts due to formatting issue in google/protobuf/empty.proto
url: https://github.com/googleapis/gapic-generator-python/issues/2490
replacements:
- paths: [
packages/google-shopping-merchant-accounts/noxfile.py,
]
before: ' "-W", # warnings as errors\n'
after: ''
count: 1
2 changes: 1 addition & 1 deletion .librarian/state.yaml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3980,7 +3980,7 @@ libraries:
tag_format: '{id}-v{version}'
- id: google-shopping-merchant-accounts
version: 1.2.0
last_generated_commit: 535d161c24965e9ed1a0b27032cc1c8b4beab818
last_generated_commit: 55ab9c6263bafb0ef1aa2d8722d190c1697bcbcb
apis:
- path: google/shopping/merchant/accounts/v1
service_config: merchantapi_v1.yaml
Expand Down
1 change: 0 additions & 1 deletion packages/google-shopping-merchant-accounts/noxfile.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -378,7 +378,6 @@ def docs(session):
shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
session.run(
"sphinx-build",
"-W", # warnings as errors

@gemini-code-assistgemini-code-assistBotDec 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing the -W flag resolves the immediate build failure caused by the upstream issue, it has the side effect of allowing all future documentation warnings to pass silently. This could mask new issues and lead to a decline in documentation quality over time.

A more targeted approach would be to suppress only the specific "Unexpected indentation" warning. This can typically be achieved in the Sphinx conf.py file using the suppress_warnings configuration.

If modifying conf.py is not feasible within the current generator setup, this change is an acceptable workaround. However, it would be beneficial to create a follow-up issue to track implementing a more targeted suppression or to remove this workaround once the upstream issue is resolved.

@partheapartheaDec 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a temporary workaround until https://github.com/googleapis/gapic-generator-python/issues/2490 can be addressed.

"-T", # show full traceback on exception
"-N", # no colors
"-b",
Expand Down
Loading