Skip to content

Introducing basic system test for Bigtable. - #1512

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:bigtable-basis-sys-test
Feb 23, 2016
Merged

Introducing basic system test for Bigtable.#1512
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:bigtable-basis-sys-test

Conversation

@dhermes

@dhermesdhermes commented Feb 20, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@dhermesdhermes added the api: bigtable Issues related to the Bigtable API. label Feb 20, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 20, 2016
tseaver
tseaver reviewed Feb 20, 2016
View reviewed changes
Comment threadsystem_tests/bigtable.py Outdated

def test_list_zones(self):
zones = CLIENT.list_zones()
self.assertEqual(sorted(zones), list(EXPECTED_ZONES))

This comment was marked as spam.

Sign in to view

@tseaver

tseaver commented Feb 20, 2016

Copy link
Copy Markdown
Contributor

Hmm, I don't get the Travis failure: we should be skipping system-tests for PRs, shouldn't we?

@dhermes

dhermes commented Feb 20, 2016

Copy link
Copy Markdown
ContributorAuthor

The Travis failure is my fault. I had to re-run the job before I remembered how things work. system_tests/bigtable.py will get imported by attempt_system_tests so the client set-up should happen at run-time not at import-time. D'oh!

@dhermes
Review changes (will be squashed).
b223311
- Using sorted() zone comparison
- Creating global CLIENT and CLUSTER at run-time rather
than at import-time
@dhermes
dhermesforce-pushed the bigtable-basis-sys-test branch from 0134f63 to b223311CompareFebruary 20, 2016 17:57
@dhermes

dhermes commented Feb 20, 2016

Copy link
Copy Markdown
ContributorAuthor

@tseaver PTAL

@tseavertseaver mentioned this pull request Feb 22, 2016
Merged
@dhermesdhermes assigned theacodes and unassigned tseaverFeb 22, 2016
@theacodes

theacodes commented Feb 23, 2016

Copy link
Copy Markdown
Contributor

LGTM.

dhermes added a commit that referenced this pull request Feb 23, 2016
@dhermes
Merge pull request#1512from dhermes/bigtable-basis-sys-test
3cfb676
Introducing basic system test for Bigtable.
@dhermes
dhermes merged commit 3cfb676 into googleapis:masterFeb 23, 2016
@dhermes
dhermes deleted the bigtable-basis-sys-test branch February 23, 2016 20:14
@dhermes

dhermes commented Feb 23, 2016

Copy link
Copy Markdown
ContributorAuthor

Arrrg! I committed a Review changes (will be squashed). commit message by mistake.

@theacodes

theacodes commented Feb 23, 2016

Copy link
Copy Markdown
Contributor

Nobody is perfect.

@dhermes

dhermes commented Feb 23, 2016

Copy link
Copy Markdown
ContributorAuthor

Lulz

@theacodestheacodes mentioned this pull request Mar 4, 2016
Merged
parthea pushed a commit that referenced this pull request Mar 2, 2026
@chalmerlowe@gcf-owl-bot
feat: Adds Python 3.14 support (#1512)
be75b64
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
@chandra-siri
Fix: Add logs on AssertionError for issue#1512(#1518)
92759bc
Adding Response.content and headers will help debug this flaky issue
which throws 403, having more verbose information would be helpful.
Closes#1512
parthea pushed a commit that referenced this pull request Apr 1, 2026
@TrevorBergeron
feat: Support window partition by geo column (#1512)
df83836
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@theacodestheacodes

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@tseaver@theacodes@googlebot