Skip to content

Beginning of HappyBase batch module. - #1515

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:begin-happybase-batch
Feb 23, 2016
Merged

Beginning of HappyBase batch module.#1515
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:begin-happybase-batch

Conversation

@dhermes

@dhermesdhermes commented Feb 21, 2016

Copy link
Copy Markdown
Contributor

@dhermesdhermes added the api: bigtable Issues related to the Bigtable API. label Feb 21, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2016
@tseavertseaver mentioned this pull request Feb 22, 2016
Merged
@dhermesdhermes assigned theacodes and unassigned tseaverFeb 22, 2016
@theacodes

theacodes commented Feb 23, 2016

Copy link
Copy Markdown
Contributor

LGTM with minor readability nit.

(as an aside, I really hate unittest2's testing style)

theacodes
theacodes reviewed Feb 23, 2016
View reviewed changes
Comment threadgcloud/bigtable/happybase/batch.py
self._batch_size = batch_size
# Timestamp is in milliseconds, convert to microseconds.
self._timestamp = self._delete_range = None
if timestamp is not None:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes

dhermes commented Feb 23, 2016

Copy link
Copy Markdown
ContributorAuthor

@jonparrottunittest2 is just a back-port of unittest, so there is no testing style to speak of. We do things guided by some notes from @tseaver.

@dhermes
dhermesforce-pushed the begin-happybase-batch branch from faf442d to bfc56f2CompareFebruary 23, 2016 20:25
dhermes added a commit that referenced this pull request Feb 23, 2016
@dhermes
Merge pull request#1515from dhermes/begin-happybase-batch
115263b
Beginning of HappyBase batch module.
@dhermes
dhermes merged commit 115263b into googleapis:masterFeb 23, 2016
@dhermes
dhermes deleted the begin-happybase-batch branch February 23, 2016 20:29
@theacodestheacodes mentioned this pull request Mar 4, 2016
Merged
parthea pushed a commit that referenced this pull request Nov 26, 2025
@BigTailWolf
chore: update token (#1515)
6d5ae70
parthea pushed a commit that referenced this pull request Mar 2, 2026
@ohmayr
chore(librarian): onboard to librarian (#1515)
abdfd72
parthea pushed a commit that referenced this pull request Apr 1, 2026
@TrevorBergeron
chore: Ignore mypy false positive (#1515)
35b05fa
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@theacodestheacodes

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@theacodes@tseaver@googlebot