Uh oh!
There was an error while loading. Please reload this page.
Adding Bigtable docs. - #1547
Conversation
dhermes
commented
Feb 26, 2016
@jgeewax PTAL as well |
| Bigtable Row | ||
| ============ | ||
| A |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
theacodes
commented
Feb 26, 2016
Does it make sense to stuff the autogen stuff under a |
theacodes
commented
Feb 26, 2016
Finished a pass, please let me know when you're ready for another round. |
| >>> from gcloud import bigtable | ||
| >>> client = bigtable.Client() | ||
| or pass in ``credentials`` and ``project`` explicitly |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermes
commented
Feb 27, 2016
@jonparrott Just pushed a new commit PTAL. I did a full pass to make sure things still made sense (since the API has changed over time) and found a few changes to make here and there (many are stylistic). |
theacodes
commented
Feb 29, 2016
This LGTM once @jgeewax's comments are addressed. (Also don't forget to squash) |
dhermes
commented
Feb 29, 2016
Thanks |
dhermes
commented
Feb 29, 2016
Dangling questions to be resolved when #1548 is. Merging now. |
jgeewax
commented
Mar 3, 2016
I see this one is merged -- are the docs up to date on both gh-pages and gcloud-python.readthedocs.org? (http://gcloud-python.readthedocs.org/en/latest/happybase-package.html doesn't look like the demo) |
jgeewax
commented
Mar 3, 2016
/cc @dhermes |
dhermes
commented
Mar 3, 2016
AFK right now but will try to sleuth. Looks like the docs build is broken somehow |
dhermes
commented
Mar 8, 2016
@jgeewax confirmed the build failure: https://readthedocs.org/projects/gcloud-python/builds/3798705/ For example: /home/docs/checkouts/readthedocs.org/user_builds/gcloud-python/checkouts/latest/docs/happybase-table.rst:4: WARNING: autodoc: failedtoimportmoduleu'gcloud.bigtable.happybase.table'; thefollowingexceptionwasraised:
Traceback (mostrecentcalllast):
File"/home/docs/checkouts/readthedocs.org/user_builds/gcloud-python/envs/latest/local/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line385, inimport_object__import__(self.modname)
File"/home/docs/checkouts/readthedocs.org/user_builds/gcloud-python/checkouts/latest/gcloud/bigtable/__init__.py", line18, in<module>fromgcloud.bigtable.clientimportClientFile"/home/docs/checkouts/readthedocs.org/user_builds/gcloud-python/checkouts/latest/gcloud/bigtable/client.py", line32, in<module>fromgrpc.betaimportimplementationsImportError: Nomodulenamedgrpc.betaI forgot I had a hack in place and will do something similar (but closer to the recommended way of fixing bad imports). |
…leep (#1547) chore: No sleep on initial attempt in exponential backoff implementation It is unintuitive that the initial attempt in the exponential backoff loop sleeps. This can lead to subtle bugs in future call sites. This patch refactors the exponential backoff to begin sleeping on the 2nd iteration so requests can be done in a single for loop.
* add AsyncAbstractObjectStream this will be the parent class for AsyncReadObjectStream and AsyncWriteObjectStream * keep _AsyncAbstractObjectStream private * Add _AsyncReadObjectStream and it's stubs * fix doc strings, add licence and type hints * pass abstract methods * add handle param * include handle in tests * remove unit tests for abstract class * edit doc string for _AsyncReadObjectStream * bucket_name and object_name cannot be NONE * bucket_name and object_name cannot be None * minor edit - add bidi-stream in doc string * add checks for invalid inputs
…low_large_results=False (#1547)
Docs serving (for now at least, as of 12:45pm Pacific on Feb. 26): https://blog.bossylobster.com/gcloud-python/latest/bigtable-usage.html