Skip to content

#1555: reload missing properties before blob download - #1559

Merged
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:1555-reload_on_missing_media_link
Mar 3, 2016
Merged

#1555: reload missing properties before blob download#1559
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:1555-reload_on_missing_media_link

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Cleaner alternative to PR #1556, with coverage.

@tseavertseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Mar 2, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 2, 2016
"""
client = self._require_client(client)
if self.media_link is None: # not yet loaded
self.reload()

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes

Copy link
Copy Markdown
Contributor

LGTM pending Travis

tseaver added a commit that referenced this pull request Mar 3, 2016
@tseaver
tseaver merged commit cba090e into googleapis:masterMar 3, 2016
@tseaver
tseaver deleted the 1555-reload_on_missing_media_link branch March 3, 2016 16:29
@theacodestheacodes mentioned this pull request Mar 4, 2016
parthea pushed a commit that referenced this pull request Nov 26, 2025
* feat: implement async oauth2 credentials
* minor cleanup
* inherit base credentials class in async credentials
* fix whitespace
* implement builder class for oauth 2.0 credentials
* feat: implement async static credentials
* revert implementing oauth2 credentials
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* update values used in tests
* update the exception raised for static refresh
* add async anonymous credentials
* update docstrings
* address PR comments
* chore: Refresh system test creds.
* fix lint issues
* add test coverage
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Carl Lundin <clundin@google.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
* feat(experimental): refresh read handles
* fix unit tests
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot