Skip to content

Add 'metric.Metric' class and its 'create' API wrapper. - #1584

Merged
tseaver merged 2 commits into
googleapis:logging-apifrom
tseaver:logging-metric_create
Mar 12, 2016
Merged

Add 'metric.Metric' class and its 'create' API wrapper.#1584
tseaver merged 2 commits into
googleapis:logging-apifrom
tseaver:logging-metric_create

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

No description provided.

@tseavertseaver added the api: logging Issues related to the Cloud Logging API. label Mar 8, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2016
@tseaver

Copy link
Copy Markdown
ContributorAuthor

Rebased to fix merge conflict after merging #1596.

Comment threadgcloud/logging/metric.py Outdated
# See the License for the specific language governing permissions and
# limitations under the License.

"""Define API Metrics."""

This comment was marked as spam.

@tseaver

Copy link
Copy Markdown
ContributorAuthor

@dhermes Amended to address your comment. PTAL

:type description: string
:param description: an optional description of the metric
"""
def __init__(self, name, filter_, client, description=''):

This comment was marked as spam.

This comment was marked as spam.

@dhermes

Copy link
Copy Markdown
Contributor

LGTM

tseaver added a commit that referenced this pull request Mar 12, 2016
Add 'metric.Metric' class and its 'create' API wrapper.
@tseaver
tseaver merged commit f2d8ad6 into googleapis:logging-apiMar 12, 2016
@tseaver
tseaver deleted the logging-metric_create branch March 12, 2016 18:24
@dhermesdhermes mentioned this pull request Apr 1, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot