Uh oh!
There was an error while loading. Please reload this page.
Fix topic subscription path patterns - #1592
Merged
tseaver merged 2 commits intoMar 9, 2016
Merged
Conversation
| from gcloud._helpers import _name_from_project_path | ||
| _topic_template = re.compile(r""" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhermes
commented
Mar 9, 2016
Contributor
FWIW I was fine without the regex 😀 |
tseaver
commented
Mar 9, 2016
ContributorAuthor
@dhermes PTAL |
dhermes
commented
Mar 9, 2016
Contributor
LGTM. Nit: |
tseaver added a commit
that referenced
this pull request
Mar 9, 2016
…terns Fix topic subscription path patterns
parthea pushed a commit
that referenced
this pull request
Nov 26, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit
that referenced
this pull request
Mar 6, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea pushed a commit
that referenced
this pull request
Mar 9, 2026
* fix: flaky system tests for resumable_media * resolving comments
parthea pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zawinski's Law strikes again!
Fix bug introduced in #1580, and surfaced in the system test failures following its merge.
Project IDs have embedded hyphens; topic / subscription names can have other punctuation.
This commit doesn't attempt to enforce the allowed punctuation, because we aren't validation user input with these patterns: we only use them to parse out project IDs / topic names / subscription names from values emitted by the back-end.