Skip to content

Adding HappyBase system tests for families and counters. - #1595

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:happybase-sys-test-counter
Mar 12, 2016
Merged

Adding HappyBase system tests for families and counters.#1595
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:happybase-sys-test-counter

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

These tests exposed an issue with regex filters. When a protobuf bytes field received a unicode object, bad things happened.

@dhermesdhermes added the api: bigtable Issues related to the Bigtable API. label Mar 10, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2016
Comment threadgcloud/bigtable/row.py Outdated

def __init__(self, regex):
self.regex = regex
self.regex = _to_bytes(regex)

This comment was marked as spam.

This comment was marked as spam.

These tests exposed an issue with regex filters. When a protobuf
bytes field received a unicode object, bad things happened.
@dhermes
dhermesforce-pushed the happybase-sys-test-counter branch from 15ca673 to 25f22baCompareMarch 11, 2016 21:16

def __init__(self, regex):
self.regex = regex
self.regex = _to_bytes(regex)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver PTAL

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver LGTY to merge?

@tseaver

Copy link
Copy Markdown
Contributor

LGTM

dhermes added a commit that referenced this pull request Mar 12, 2016
Adding HappyBase system tests for families and counters.
@dhermes
dhermes merged commit 71fe17b into googleapis:masterMar 12, 2016
@dhermes
dhermes deleted the happybase-sys-test-counter branch March 12, 2016 00:28
@dhermesdhermes mentioned this pull request Apr 1, 2016
parthea added a commit that referenced this pull request Nov 24, 2025
* chore(deps): update all dependencies
* revert
---------
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
* fix: remove token_info call from token refresh path
* update secret
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Mar 6, 2026
In response to internal issue 285136859.
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
…PU (#1595)
Co-authored-by: Chandra Shekhar Sirimala <chandrasiri@google.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
…havior comparison (#1595)
* refactor: refactor read_csv and tests based on bigquery vs. pandas behavior comparison
* address comments
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot