Skip to content

Add system test for 'logger.log_text' and 'logger.log_struct'. - #1609

Merged
tseaver merged 1 commit into
googleapis:logging-apifrom
tseaver:logging-system_test-logger_log
Mar 17, 2016
Merged

Add system test for 'logger.log_text' and 'logger.log_struct'.#1609
tseaver merged 1 commit into
googleapis:logging-apifrom
tseaver:logging-system_test-logger_log

Conversation

@tseaver

@tseavertseaver commented Mar 15, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@tseavertseaver added the api: logging Issues related to the Cloud Logging API. label Mar 15, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2016
@tseavertseaver mentioned this pull request Mar 15, 2016
Merged
dhermes
dhermes reviewed Mar 15, 2016
View reviewed changes
Comment threadsystem_tests/logging_.py


def setUpModule():
_helpers.PROJECT = TESTS_PROJECT

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseavertseaver mentioned this pull request Mar 15, 2016
Closed
@tseavertseaver changed the title System test for 'logger.log_text' and 'logger.log_struct'.Add system test for 'logger.log_text' and 'logger.log_struct'.Mar 15, 2016
@tseavertseaver mentioned this pull request Mar 16, 2016
Closed
@tseaver

tseaver commented Mar 17, 2016

Copy link
Copy Markdown
ContributorAuthor

@dhermes any remaining issues?

@tseaver

tseaver commented Mar 17, 2016

Copy link
Copy Markdown
ContributorAuthor

Rebased after merging #1616 to the logging-api branch.

@dhermes

dhermes commented Mar 17, 2016

Copy link
Copy Markdown
Contributor

LGTM. The eventual consistency hack might be easier to find if you factor it out into a helper (like is done in the bigtable test).

@tseaver

tseaver commented Mar 17, 2016

Copy link
Copy Markdown
ContributorAuthor

The eventual consistency hack might be easier to find if you factor it out into a helper (like is done in the bigtable test).

I've been thinking about a more generic retry wrapper (per #1619).

tseaver added a commit that referenced this pull request Mar 17, 2016
@tseaver
Merge pull request#1609from tseaver/logging-system_test-logger_log
57fed8a
Add system test for 'logger.log_text' and 'logger.log_struct'.
@tseaver
tseaver merged commit 57fed8a into googleapis:logging-apiMar 17, 2016
@tseaver
tseaver deleted the logging-system_test-logger_log branch March 17, 2016 13:45
@dhermes

dhermes commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

@tseaver I made a generic retry wrapper in #535

@dhermesdhermes mentioned this pull request Apr 1, 2016
Merged
parthea pushed a commit that referenced this pull request Mar 6, 2026
@alvarowolfx
test: enable copy table tests (#1609)
9101604
parthea pushed a commit that referenced this pull request Apr 1, 2026
@jialuoo@tswast
docs: add details forbigquery_connectionin@bpd.udfdocstring (#…
ffd5304
…1609)
* chore: add details for bigquery_connection in udf docstring
* quick fix
* Update bigframes/functions/_function_session.py
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
* resolve the comments
* sync the docstring
---------
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot