Skip to content

Add system test for 'Sink.create', w/ Storage bucket destination - #1628

Merged
tseaver merged 1 commit into
googleapis:logging-apifrom
tseaver:logging-system_test-sink_create
Mar 22, 2016
Merged

Add system test for 'Sink.create', w/ Storage bucket destination#1628
tseaver merged 1 commit into
googleapis:logging-apifrom
tseaver:logging-system_test-sink_create

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

Uses #1613 as a base.

@tseavertseaver added the api: logging Issues related to the Cloud Logging API. label Mar 17, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2016
@tseavertseaver changed the title Add system test for 'Sink.create'.Add system test for 'Sink.create', w/ Storage bucket destinationMar 17, 2016
@dhermes

Copy link
Copy Markdown
Contributor

LGTM pending rebase.

Also, FWIW if you rebase both this and #1613, then merge this, then GitHub will auto-close #1613 as merged.

@tseaver

Copy link
Copy Markdown
ContributorAuthor

N.B. that we cannot merge this PR until we have solved the problem outlined in #1614 (system tests have to run as a user with permission to create / update / delete sinks, i.e. with Owner role).

@dhermes

Copy link
Copy Markdown
Contributor

Noted

@tseavertseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 18, 2016
@tseavertseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 22, 2016
tseaver added a commit that referenced this pull request Mar 22, 2016
Add system test for 'Sink.create', w/ Storage bucket destination
@tseaver
tseaver merged commit 0adbd70 into googleapis:logging-apiMar 22, 2016
@tseaver
tseaver deleted the logging-system_test-sink_create branch March 22, 2016 16:13
@dhermesdhermes mentioned this pull request Apr 1, 2016
parthea pushed a commit that referenced this pull request Apr 1, 2026
* chore: blob.display to support width and height params
* wording
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot