Skip to content

#798: Add support for auto-acknowledging pulled messages. - #1637

Closed
tseaver wants to merge 2 commits into
googleapis:masterfrom
tseaver:798-jgeewax_strategy
Closed

#798: Add support for auto-acknowledging pulled messages.#1637
tseaver wants to merge 2 commits into
googleapis:masterfrom
tseaver:798-jgeewax_strategy

Conversation

@tseaver

@tseavertseaver commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

Follows @jgeewax's suggested implementation.

Closes#798.

Hold off merging until comparing with the alternate implementation suggested by @tmatsuo (#1636).

@tseavertseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: pubsub Issues related to the Pub/Sub API. labels Mar 18, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2016
@coveralls

coveralls commented Mar 18, 2016

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 3d1bb30 on tseaver:798-jgeewax_strategy into 98edc64 on GoogleCloudPlatform:master.

@tseaver

tseaver commented Mar 18, 2016

Copy link
Copy Markdown
ContributorAuthor

Ugh, when did @coveralls turn back into a noisy commenter?

@tseavertseaver mentioned this pull request Mar 18, 2016
Merged
@tseaver

tseaver commented Mar 18, 2016

Copy link
Copy Markdown
ContributorAuthor

Ugh, when did @coveralls turn back into a noisy commenter?

I just disabled @coveralls commenting on the project page.

@dhermes

dhermes commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

How did you disable it? (Primarily I want to make sure the webhook is still active.)

@dhermes

dhermes commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

Looks fine (at least no issues with the code, though I realize this is a "design"-off challenge)

@tseaver

tseaver commented Mar 18, 2016

Copy link
Copy Markdown
ContributorAuthor

There are separate flags for "Leave Comments" and "Use Status API":

screenshot from 2016-03-18 14 04 20

@theacodes

theacodes commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

FWIW, codecov can be bit better than coveralls at times.

On Fri, Mar 18, 2016 at 11:06 AM Tres Seaver notifications@github.com
wrote:

There are separate flags for "Leave Comments" and "Use Status API":

[image: screenshot from 2016-03-18 14 04 20]
https://cloud.githubusercontent.com/assets/242750/13887533/882a7bae-ed12-11e5-9d6c-e9b8c880f16f.png

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1637 (comment)

@dhermes

dhermes commented Mar 18, 2016

Copy link
Copy Markdown
Contributor

We don't have any allegiance, just in the "ain't broke" state

jgeewax
jgeewax reviewed Mar 20, 2016
View reviewed changes
Comment threaddocs/pubsub-usage.rst Outdated
... batch.publish('this is the first message_payload')
... batch.publish('this is the second message_payload',
... attr1='value1', attr2='value2')
>>> from gcloud.pubsub.subscription import AutoAck

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseavertseaver mentioned this pull request May 12, 2016
Closed
@tseaver

tseaver commented Jul 11, 2016

Copy link
Copy Markdown
ContributorAuthor

In favor of #1636

@tseavertseaver closed this Jul 11, 2016
@tseaver
tseaver deleted the 798-jgeewax_strategy branch July 11, 2016 16:51
parthea pushed a commit that referenced this pull request Mar 9, 2026
@agrawalradhika-cell@chandra-siri
feat: Auto enable mTLS when supported certificates are detected (#1637)
5c1e6b9
The Python SDK will use a hybrid approach for mTLS enablement:
If the GOOGLE_API_USE_CLIENT_CERTIFICATE environment variable is set
(either true or false or any value), the SDK will respect that setting.
This is necessary for test scenarios and users who need to explicitly
control mTLS behavior.
If the GOOGLE_API_USE_CLIENT_CERTIFICATE environment variable is not
set, the SDK will automatically enable mTLS only if it detects Managed
Workload Identity (MWID) or X.509 Workforce Identity Federation (WIF)
certificate sources. In other cases where the variable is not set, mTLS
will remain disabled.
---------
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
Co-authored-by: Chandra Shekhar Sirimala <chandrasiri@google.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
@release-please@chandra-siri
chore(main): release 3.7.0 (#1621)
620303e
🤖 I have created a release *beep* *boop*
---
##
[3.7.0](googleapis/python-storage@v3.6.0...v3.7.0)
(2025-12-09)
### Features
* Auto enable mTLS when supported certificates are detected
([#1637](googleapis/python-storage#1637))
([4e91c54](googleapis/python-storage@4e91c54))
* Send entire object checksum in the final api call of resumable upload
([#1654](googleapis/python-storage#1654))
([ddce7e5](googleapis/python-storage@ddce7e5))
* Support urllib3 &gt;= 2.6.0
([#1658](googleapis/python-storage#1658))
([57405e9](googleapis/python-storage@57405e9))
### Bug Fixes
* **bucket:** Move blob fails when the new blob name contains characters
that need to be url encoded
([#1605](googleapis/python-storage#1605))
([ec470a2](googleapis/python-storage@ec470a2))
---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
---------
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Chandra Shekhar Sirimala <chandrasiri@google.com>
parthea pushed a commit that referenced this pull request Apr 1, 2026
@tswast
feat: addbigframes.bigquery.st_distancefunction (#1637)
65e9b49
* feat: add `bigframes.bigquery.st_distance` function
* fix docstring
* add tests
* add tests
* type checks
* make sure shapely.Point is available
* fix docstrings, add null row test
* GeoSereies typo
* Update bigframes/dtypes.py
* Update bigframes/dtypes.py
* Update third_party/bigframes_vendored/geopandas/geoseries.py
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: pubsubIssues related to the Pub/Sub API.cla: yesThis human has signed the Contributor License Agreement.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tseaver@coveralls@dhermes@theacodes@jgeewax@googlebot